Clothes Dryer CEF (and EF bugfix) #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I started to second guess myself on whether EF stands for Energy Factor or Efficiency Factor. The ANSI/RESNET/ICC standard says "efficiency factor", and you can find a lot of references to that term in Google. But the DOE Standards rulemaking makes it clear that it's "energy factor". See https://www1.eere.energy.gov/buildings/appliance_standards/standards.aspx?productid=50&action=viewlive, click on "78 FR 49608", and search for "energy factor". |
|
Add note for EF. Also add "formerly know as EfficiencyFactor" or something like this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the newer CEF metric for clothes dryers. Also fixes EF to be
EnergyFactor, notEfficiencyFactor.