Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing docs for BPI2400Inputs/CalibrationQualification #138

Merged
merged 1 commit into from
Aug 3, 2018

Conversation

nmerket
Copy link
Contributor

@nmerket nmerket commented Jul 30, 2018

Fixes #99

It now reads:

This identifies which data quality requirements (if any) were met by the bills for the relevant energy source and therefore which calibration metrics (if any) are used to determine whether the calibrated model is accepted.

@nmerket nmerket added this to the v2.3 milestone Jul 30, 2018
@nmerket nmerket requested a review from GamalielL July 30, 2018 22:05
@GamalielL
Copy link

Is there some mechanic besides commenting to complete a review? This looks good to me.

@shorowit
Copy link
Contributor

@GamalielL If you click on the "Files changed" tab above, there is a button that says "Review changes".

@GamalielL
Copy link

GamalielL commented Jul 31, 2018 via email

@nmerket nmerket merged commit 48225f1 into master Aug 3, 2018
@nmerket nmerket deleted the 99_bpi2400_docchange branch August 3, 2018 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants