-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow multiple Attic Floor Insulation and Attic Roof Insulation nodes #28
Comments
Oh boy, this takes something that's already kind of complicated and makes in complicateder. I see your reasoning and it makes sense. It would also be "non-breaking" in the strict sense that old files would validate against the updated schema. However, the extra layer of multiplicity it adds would be a real bear for receiving systems (one of which I maintain now), so I'm hesitant to jump on this one without a wider discussion and consensus. |
Because this is backwards compatible, it wouldn't cause any problems for On Tue, Apr 7, 2015 at 3:36 PM, Noel Merket [email protected]
|
Agreed. On Tue, Apr 7, 2015 at 12:44 PM GamalielL [email protected] wrote:
|
I'm adding the 2.2 milestone because we should decide whether we're doing this or not doing this for that release. |
Right now I have the following tally then:
Reasons to add
Reasons not to add
ConclusionI'm leaning towards not doing this. @andrulis if you can persuade us otherwise, now is your chance. |
Right now to model an attic in a way that Savvy can interpret it for NYSERDA, we need to artificially create multiple attics (one attic for every surface in the attic) and add an artificial area of 1 (since the Area node has a min exclusive of 0) when we are referring to a roof section. There is no way to tell just how many attic spaces are actually in the home and the receiving systems needs to know to ignore if an attic Area = 1. |
As I understand it, what we are doing at NYSERDA is actually the original intent of how to use the attic nodes in HPXML (with the exception of the Area = 1 workaround that is needed due to one of the savings reasonableness rules at NYSERDA). Since this process works for all of the modeling tools or they have a functioning workaround in place, I vote that we maintain the status quo. |
@andrulis can you explain why you end up needing to create Area=1 attics? On Mon, Nov 30, 2015 at 6:10 PM, jjaugenbraun [email protected]
|
Hi Gamaliel, Given the way NYSERDA attic insulation measures are defined, if the actual attic has improvements to both the AtticFloorInsulation and the AtticRoofInsulation systems, that would be conveyed as two separate attics in HPXML and two separate measures. Since each of those attics requires an area to be specified according to the NYSERDA data set and the HPXML schema does not permit an area of 0, we are using 1 so we can easily ignore these areas for reporting purposes and avoid double counting attic area (since both the AtticFloorInsulation and AtticRoofInsulation would be in the same actual attic in this case). Thanks, |
JJ - That makes sense from an HPXML perspective, but I still don't On Mon, Nov 30, 2015 at 10:43 PM, jjaugenbraun [email protected]
|
Having to do a workaround hack like that isn't desirable. If making this change makes it so you don't have to do that, I'm all for it. I guess the question I have is whether allowing multiple If I could do this all over again I'd put the roof insulation on the |
@GamalielL I'm not sure how often this happens in real life. @andrulis Do you have a sense for that? @nmerket Since we have a workaround in place and this is a breaking change that not everyone may have had a chance to review, do you think we could table this change until v2.3? |
The real life scenario is that only part of the attic floor is insulated. Now, I have to create separate attic nodes for each variation in attic floor or roof insulation. So instead of the attic indicating the concept of the attic 'space' and the floor and roof insulation indicating the concept of the 'surfaces' of that 'space', we have to create a separate 'space' for each 'surface' and suddenly I have no idea if this building had one attic or multiple attics. I do like the idea of moving the roof insulation to the Roof node. Perhaps we can do that in this release and deprecate the current attic roof insulation node with the idea to remove it in 3.0 |
The problem is that Attics are halfway between a standalone insulation
If we leave the existing insulation nodes inside Attic, then we can On Wed, Dec 2, 2015 at 12:52 PM, andrulis [email protected] wrote:
|
I will add an area to the insulation elements and post a pull request. Stay posted. |
Noel - Please review my proposal first. On Thu, Dec 3, 2015 at 2:52 PM, Noel Merket [email protected]
|
@GamalielL, will do. |
@GamalielL I think I like what you're proposing here, but having both in there for v2.2 is going to be a compatibility nightmare for receiving systems. Even though it's technically backwards compatible, it breaks the spirit of backwards compatibility. It will make anyone receiving HPXML have to parse both places and interpret it differently based on which elements are used (old or new). What if both are specified? A general re-working of attics is a great idea and it should be done. In v3.0. |
Let's leave this alone for now then. I don't think it is adversely On Thu, Dec 17, 2015 at 2:15 PM, Noel Merket [email protected]
|
If you guys had seen the rather crappy workaround we had to do to make this work with the NYSERDA program, I think you'd be more agreeable to making the change now. I really liked Gamaliel's proposal and I would argue that it is better to add it now and deprecate the existing functionality in v3. That is a normal software versioning process. Add a replacement feature in one release and deprecate the old feature in the next. This gives software vendors time to phase in the change rather than having to scramble to adjust once v3 hits. |
Still not quite sure what to do here, guys. Let's talk it through on the call Thursday. |
This is addressed by the proposed attic refactor for v3. |
When modeling an attic, there may be multiple insulation sections for the floor or roof yet really be part of the same attic node. Currently, if there are multiple insulations sections, we need to artificially create multiple attics. Instead, I propose we can allow multiple attic floor insulation nodes and multiple attic roof insulation nodes.
The text was updated successfully, but these errors were encountered: