Fix SP precision builds #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greole
force-pushed
the
fix/sp_scalar_build
branch
from
5be7722 to
351012c
Compare
greole
force-pushed
the
fix/sp_scalar_build
branch
from
90522c8 to
07410be
Compare
Co-authored-by: Tobias Ribizel <[email protected]>
greole
force-pushed
the
fix/sp_scalar_build
branch
from
94d0439 to
2f3c804
Compare
greole
commented
Jun 10, 2024
chihta-wang
reviewed
Jun 10, 2024
CHANGELOG.md
Outdated
| @@ -5,6 +5,8 @@ SPDX-License-Identifier: GPL-3.0-or-later | |||
| --> | |||
|
|
|||
| # 0.5.4 (unreleased) | |||
| - Add support for SP scalars and determine label and scalar size from env variable [PR #120](https://github.com/hpsim/OGL/pull/120) | |||
| - Notify user of a unsupported executor argument [PR #118](https://github.com/hpsim/OGL/pull/118) | |||
| - Notify user of a unsupported executor argument [PR #] | |||
| - Add a list of all OGL authors [PR #113](https://github.com/hpsim/OGL/pull/113) | |||
There was a problem hiding this comment.
Should be: Add a list of all OGL authors PR #126
There was a problem hiding this comment.
But in generall I think this not even needed to add here, since it is not relevant for users.
chihta-wang
reviewed
Jun 10, 2024
CHANGELOG.md
Outdated
| @@ -5,6 +5,8 @@ SPDX-License-Identifier: GPL-3.0-or-later | |||
| --> | |||
|
|
|||
| # 0.5.4 (unreleased) | |||
| - Add support for SP scalars and determine label and scalar size from env variable [PR #120](https://github.com/hpsim/OGL/pull/120) | |||
| - Notify user of a unsupported executor argument [PR #118](https://github.com/hpsim/OGL/pull/118) | |||
| - Notify user of a unsupported executor argument [PR #] | |||
| - Add a list of all OGL authors [PR #113](https://github.com/hpsim/OGL/pull/113) | |||
| - Replace #ifdef include guard with #pragma once [PR #113](https://github.com/hpsim/OGL/pull/113) | |||
There was a problem hiding this comment.
Replace #ifdef include guard with #pragma once PR #126
greole
commented
Jun 10, 2024
CHANGELOG.md
Outdated
| @@ -5,6 +5,8 @@ SPDX-License-Identifier: GPL-3.0-or-later | |||
| --> | |||
|
|
|||
| # 0.5.4 (unreleased) | |||
| - Add support for SP scalars and determine label and scalar size from env variable [PR #120](https://github.com/hpsim/OGL/pull/120) | |||
| - Notify user of a unsupported executor argument [PR #118](https://github.com/hpsim/OGL/pull/118) | |||
| - Notify user of a unsupported executor argument [PR #] | |||
| - Add a list of all OGL authors [PR #113](https://github.com/hpsim/OGL/pull/113) | |||
There was a problem hiding this comment.
But in generall I think this not even needed to add here, since it is not relevant for users.
greole
commented
Jun 10, 2024
chihta-wang
reviewed
Jun 10, 2024
CHANGELOG.md
Outdated
| - Add a list of all OGL authors [PR #113](https://github.com/hpsim/OGL/pull/113) | ||
| - Replace #ifdef include guard with #pragma once [PR #113](https://github.com/hpsim/OGL/pull/113) | ||
| - Add a list of all OGL authors [PR #126](https://github.com/hpsim/OGL/pull/126) | ||
| - Replace #ifdef include guard with #pragma once [PR #126](https://github.com/hpsim/OGL/pull/126) | ||
| - Switch to SPDX headers, fix formatting issue[PR #112](https://github.com/hpsim/OGL/pull/112) |
There was a problem hiding this comment.
Switch to SPDX headers, fix formatting issuePR #122
greole
commented
Jun 10, 2024
CHANGELOG.md
Outdated
| - Add a list of all OGL authors [PR #113](https://github.com/hpsim/OGL/pull/113) | ||
| - Replace #ifdef include guard with #pragma once [PR #113](https://github.com/hpsim/OGL/pull/113) | ||
| - Add a list of all OGL authors [PR #126](https://github.com/hpsim/OGL/pull/126) | ||
| - Replace #ifdef include guard with #pragma once [PR #126](https://github.com/hpsim/OGL/pull/126) | ||
| - Switch to SPDX headers, fix formatting issue[PR #112](https://github.com/hpsim/OGL/pull/112) |
There was a problem hiding this comment.
Suggested change
| - Switch to SPDX headers, fix formatting issue[PR #112](https://github.com/hpsim/OGL/pull/112) | |
| - Switch to SPDX headers, fix formatting issue[PR #122](https://github.com/hpsim/OGL/pull/112) |
greole
commented
Jun 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves build for SP precission.
OGL_DP_LABELSobsolete. This PR fixes Compiling against single precision OpenFOAM leads to undefined symbol errors #119.Additional changes:
-DOGL_USE_EXTERNAL_GINKGO=ONno backend needs to be specified