Add request rate limit to proxy #227
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janefawkes
changed the title
ai
reviewed
Jun 7, 2024
ai
reviewed
Jun 7, 2024
ai
reviewed
Jun 7, 2024
ai
reviewed
Jun 7, 2024
ai
reviewed
Jun 8, 2024
|
Now you need to fix tests (it is better to add some test for rate limit too) and we are ready to merge. You can run tests by You also need to fix ESLint warnings by calling |
|
ESLint warnings are fixed now. Not sure what to do with tests, though. I am a bit stuck with them and I don't really know how to ensure proper coverage |
janefawkes
commented
Jun 9, 2024
| @@ -8,7 +8,7 @@ | |||
| }, | |||
| "scripts": { | |||
| "start": "tsx watch index.ts", | |||
| "test": "FORCE_COLOR=1 pnpm run /^test:/", | |||
There was a problem hiding this comment.
Changed it for the dev purposes, gonna add this line back in the next commit.
|
Pull request auto-reviewer [ ] If you added a new dependency, check our requirements. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #168
I sort of tested this by running the proxy and spamming it with batches of requests (like this). It works on my machine™, but
pnpm testdoesn't quite agree with it.Would love to hear any sort of feedback on this, because I'm not sure if I'm moving in the right direction or not.
Additional changes: proxy config and error handling have been divorced from the
createProxyServerimplementation.