Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add request rate limit to proxy #168

Open
3 tasks
ai opened this issue Apr 17, 2024 · 3 comments
Open
3 tasks

Add request rate limit to proxy #168

ai opened this issue Apr 17, 2024 · 3 comments
Assignees
Labels

Comments

@ai
Copy link
Contributor

ai commented Apr 17, 2024

To prevent abusing our public CORS proxy

  • Allow only 500 request in a minute to the same domain from the same IP-address.
  • Allow only 5000 request in a minute to any domain from the same IP-address.
  • Add to proxy/README.md mention of this method.

On passing those limits:

  1. Print to console (we will need it to debug)
  2. Do not cancel response, just postpone (so client will not see an error, just slower connection).

These changes need to be done in proxy/. It will be cool to have tests, but if they are not stable or hard to make, we can avoid it.

@ai ai moved this to Ready to Take in Slow Reader Tasks Apr 17, 2024
@ai ai removed the Blocked label Apr 27, 2024
@toplenboren
Copy link
Contributor

Allow only 5000 request to any domain from the same IP-address.

What if I really like to read someone's blog :-) shall we reset the counter monthly?

@ai
Copy link
Contributor Author

ai commented Apr 28, 2024

@toplenboren it is in a minute :) Fixed in task’s text.

@janefawkes
Copy link

hi, can i take this one?

@ai ai moved this from Ready to Take to In Progress in Slow Reader Tasks Jun 5, 2024
@ai ai moved this from In Progress to Ready to Take in Slow Reader Tasks Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Ready to Take
Development

Successfully merging a pull request may close this issue.

3 participants