Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing array dereference reported by Mike on the mailing list #1

Merged
merged 1 commit into from
May 2, 2015

Conversation

hollie
Copy link

@hollie hollie commented Mar 21, 2015

As reported by Mike on the mailing list, the existing code fails to run on his setup.

The patch in this commit fixes his issue.

Note: I was unable to reproduce the problem he reported.

@hplato
Copy link
Owner

hplato commented Mar 21, 2015

I think this is an issue with earlier versions of perl. I saw this a few times before I upgraded perl. I’ll add the patch and test.

On Mar 21, 2015, at 10:34 AM, Lieven Hollevoet [email protected] wrote:

As reported by Mike on the mailing list, the existing code fails to run on his setup.

The patch in this commit fixes his issue.

Note: I was unable to reproduce the problem he reported.

You can view, comment on, or merge this pull request online at:

#1 #1
Commit Summary

Fix missing array dereference reported by Mike on the mailing list
File Changes

M lib/json_server.pl https://github.com/hplato/misterhouse/pull/1/files#diff-0 (6)
Patch Links:

https://github.com/hplato/misterhouse/pull/1.patch https://github.com/hplato/misterhouse/pull/1.patch
https://github.com/hplato/misterhouse/pull/1.diff https://github.com/hplato/misterhouse/pull/1.diff

Reply to this email directly or view it on GitHub #1.

@hollie
Copy link
Author

hollie commented Apr 25, 2015

Hey @hplato, for your reference (in case you get later pull requests): if you want to test and patch from a pull request you just need to click the 'merge' button in the github interface and update your clone.

Best regards,
Lieven.

hplato pushed a commit that referenced this pull request Apr 25, 2015
@hplato hplato merged commit c6537a5 into hplato:ia7 May 2, 2015
hplato pushed a commit that referenced this pull request Mar 27, 2016
Socket_Item print _log clean up
hplato pushed a commit that referenced this pull request Oct 2, 2016
Update Master 2016-05-20
@hollie hollie deleted the ia7_fix_array_dereference branch January 8, 2017 17:12
hplato pushed a commit that referenced this pull request Aug 13, 2017
hplato added a commit that referenced this pull request Aug 13, 2017
hplato pushed a commit that referenced this pull request Dec 28, 2020
hplato pushed a commit that referenced this pull request Dec 28, 2020
hplato pushed a commit that referenced this pull request Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants