Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

97/vertical/puppet-scripts-creation #193

Closed
wants to merge 9 commits into from

Conversation

NiklasKoehnecke
Copy link
Contributor

Closes #97.
This creates a button on the request index page to show a puppet script for each accepted request.
The button is temporary until #100 is completed.

@NiklasKoehnecke NiklasKoehnecke added the WIP work is still in progess for this PR label Dec 13, 2018
@henleo henleo force-pushed the 97/frontend/puppet-scripts branch from 6c062a4 to 7c405b3 Compare January 14, 2019 11:59
Copy link
Contributor

@Adrian-St Adrian-St left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

def puppet_node_script(request)

puppet_string =
'class node_vm-%s {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The example files given by the admin were different than the US.

Suggested change
'class node_vm-%s {
'class node_$%s {

@NiklasKoehnecke
Copy link
Contributor Author

NiklasKoehnecke commented Jan 28, 2019

was merged with #234

@arne-z arne-z deleted the 97/frontend/puppet-scripts branch February 7, 2019 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WIP work is still in progess for this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants