Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User angeben bei VM-Anfrage #99

Closed
6 tasks done
arne-z opened this issue Nov 23, 2018 · 2 comments
Closed
6 tasks done

User angeben bei VM-Anfrage #99

arne-z opened this issue Nov 23, 2018 · 2 comments
Assignees
Labels
prio: high This is a high priority issue.

Comments

@arne-z
Copy link
Contributor

arne-z commented Nov 23, 2018

Beschreibung
Ich als Nutzer möchte beim dem Request einer VM angeben wer außer mir Zugriff auf die VM bekommen soll damit auch andere beteiligte Personen mitarbeiten können.

Akzeptanzkriterien

  • Es gibt eine Liste in der die schon hinzugefügten Extranutzer stehen
  • Dieses ist initial leer
  • Es können zusätzliche User anhand ihrer HPI E-Mail Adresse (bzw. dem Teil vor dem @) angegeben werden (mittels einem +-Button) unter der Liste
  • Nutzer können durch das Klicken auf das x wieder entfernt werden (via einem x ganz rechts in der Liste)
  • Es kann den einzelnen hinzugefügten Nutzern ein Label "Sudo" gegeben werden (via Checkbox, links von dem x zum Entfernen)
  • Ein Nutzer mit Sudorechten ist außerdem farblich hinterlegt

Priorität
Hoch

Aufwandsschätzung

@arne-z arne-z added prio: high This is a high priority issue. team scaffold labels Nov 23, 2018
@bdaase bdaase mentioned this issue Nov 30, 2018
7 tasks
@skydivin4ng3l
Copy link
Contributor

related to #97

@Kenneth-Schroeder Kenneth-Schroeder self-assigned this Dec 2, 2018
JonasZim pushed a commit that referenced this issue Dec 4, 2018
This was referenced Dec 6, 2018
Kenneth-Schroeder added a commit that referenced this issue Dec 10, 2018
* add table to add users in requests #99

* Add the option to assign users to requests

* Add the option to select users with sudo rights

* Fix linter errors

* add required migrations

* autocorrect for rubocop

* fix parts of codefactor

* try to fix more codebeat

* try to fix more codebeat

* try to fix more codebeat

* try to fix more codefactor

* try to fix more codefactor
MaximilianKoenig pushed a commit that referenced this issue Jan 13, 2019
* add table to add users in requests #99

* Add the option to assign users to requests

* Add the option to select users with sudo rights

* Fix linter errors

* add required migrations

* autocorrect for rubocop

* fix parts of codefactor

* try to fix more codebeat

* try to fix more codebeat

* try to fix more codebeat

* try to fix more codefactor

* try to fix more codefactor

* fix codefactor

* this commit has only minor changes

* Add a CSS class to multi select fields

* add select2 gem in order to make it great (not again)

* fix merge bug

* make rubocop happy

* fix reload issue

* hopefully make codefactor happy

* hopefully make codefactor happy

* hopefully make codefactor happy

* hopefully make codefactor happy

* hopefully make codefactor happy

* test style changes

* Merge branch '99/scaffold/add-user-to-vm-request' of https://github.com/hpi-swt2/vm-portal into 99/scaffold/add-user-to-vm-request

# Conflicts:
#	app/views/requests/_form.html.erb

* Adds a description to requests
Improves adding sudo users to requests
Adds first tests for sudo user assignments

* Fix Travis by including nil check before assigning sudo users

* update test wimi to employee

* adjust color of selected items

* Refactor create method in request controller
Add model tests
Add some view tests

* Fixes multiple association creation
Removes the Description from the index page

* makes minor refactoring and adds tests for this in request model

* Fixes functionality of adding users to requests and adds tests even though some of them are failing still

* Provisionally fixes the tests

* Fix tests

* Fix tests

* Hopefully fixes tests

* rubocop auto fixes and minor refactoring

* Fix Test

* add DatabaseCleaner gem in order to reset database after each test

* autocorrect

* fix some codefactor

* Fix Tests

* revert DatabaseCleaner
@bdaase
Copy link
Contributor

bdaase commented Jan 14, 2019

Looks good to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
prio: high This is a high priority issue.
Projects
None yet
Development

No branches or pull requests

6 participants