Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

External fetch/push #394

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

External fetch/push #394

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ca689d4
add support for external fetch and push via OSProcess
tom95 Oct 15, 2022
2529a47
if we allow external pushes, all remote types are supported
tom95 Oct 15, 2022
ca57611
fix invoking command on windows
tom95 Oct 15, 2022
f9c2cbf
escape spaces in path to working dir (thanks @LinqLover)
tom95 Oct 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/FileSystem-Git.package/FileSystemGitRepository.class/instance/externalGitDo.showText..st
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
git porcelain - external
externalGitDo: aCommandLineSuffix showText: aBoolean
| res |
res := self externalCommand: ('git -C {1} {2}' format: {repository workingDir. aCommandLineSuffix}).
res := self externalCommand: ('git -C {1} {2}' format: {repository workingDir pathName copyReplaceAll: ' ' with: '\ '. aCommandLineSuffix}).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about quotes? Afaik linux filenames are allowed to contain double quotes (") as well :P

res first
ifFalse: [self error: res second]
ifTrue: [aBoolean ifTrue: [self inform: res second] ifFalse: [Transcript showln: res second]]
2 changes: 1 addition & 1 deletion src/FileSystem-Git.package/FileSystemGitRepository.class/methodProperties.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
"createBranchNamed:at:" : "jr 3/4/2020 00:47",
"expandRemoteRef:" : "pre 6/15/2018 16:04",
"externalCommand:" : "tobe 10/15/2022 03:44",
"externalGitDo:showText:" : "tobe 10/15/2022 03:15",
"externalGitDo:showText:" : "tobe 10/15/2022 14:35",
"externalPush:toRemote:" : "tobe 10/15/2022 07:45",
"fetchAllExternalFrom:" : "tobe 10/15/2022 03:42",
"fetchFrom:" : "jr 5/14/2021 22:08",
Expand Down