Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design GUI according to Icons #97

Merged
merged 4 commits into from
Jun 21, 2021
Merged

Conversation

SebastianWagner2
Copy link
Contributor

@SebastianWagner2 SebastianWagner2 commented Jun 20, 2021

Closes: #100

Alter Layout of GUI so it is more readable with icons

@SebastianWagner2 SebastianWagner2 changed the title Add Icons to GUI Design GUI according to Icons Jun 20, 2021
@Benjamin-Frost Benjamin-Frost marked this pull request as draft June 20, 2021 19:52
@SebastianWagner2 SebastianWagner2 marked this pull request as ready for review June 21, 2021 09:43
bottomFraction: 0 offset: self buttonHeight;
leftFraction: 0;
topFraction: 0;
rightFraction: 0.15;
Copy link
Contributor

@Toalaah Toalaah Jun 21, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this value be changed to a class var or something similar? I see that we use the same value in testingEntityFrame as well. (Specifically, the 0.15 for rightFraction)

Copy link
Contributor

@Toalaah Toalaah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SebastianWagner2 SebastianWagner2 requested review from Benjamin-Frost and removed request for oleksandrmartemiano June 21, 2021 10:00
@SebastianWagner2 SebastianWagner2 merged commit 157d33e into dev Jun 21, 2021
@SebastianWagner2 SebastianWagner2 deleted the feat/32-use-icons-in-GUI-2 branch June 21, 2021 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change Layout
3 participants