-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
misc-3 #225
Conversation
…ers collections and sunit)
Those are intended as technical keys and not for human reading. Don't challenge PDF viewers out there with handling quotes and spaces in such keys. Note that there are many further occurences of this pattern in several code environments. I didn't bother for them now.
Some readers (e.g., PDF.js) depend on this but otherwise treat the URL as relative.
Supported by 61df36d 🤓
@LinqLover Do we have a tag for the print release commit (can't see them in the app apparently)? If yes, I am fine with merging it into master and adding it to the CI. Only thing that I find important: It should be clear that the in-image format is an extension, not an elementary part of the project. I would like to avoid a situation in the future in which an improvement to the book does not happen bc it would conflict with the extractor in some way. |
@codeZeilen Ouch, sorry for the late reply. Yes, there's a 6.0 release: https://github.com/hpi-swa-lab/SqueakByExample-english/releases/tag/6.0
+1. Will document that. |
@codeZeilen Very brief review would be great, in particular for the aesthetic change on the title page (351f990) :)