Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise my description of UIManager and projects #143

Merged
merged 5 commits into from
Nov 9, 2022

Conversation

LinqLover
Copy link
Collaborator

The term "UI system" is non-Squeakish, so only use it once. Don't talk too much about the implementation details of the responsibility at this point. Don't suggest that there could be other, less idiomatic ways to retrieve a UIManager.

The term "UI system" is not-Squeakish, so onlyuse it once. Don't talk too much about the implementation details of the responsibility at this point. Don't suggest that there could be other, less idiomatic ways to retrieve a UIManager.
@LinqLover LinqLover added the enhancement New feature or request label Oct 10, 2022
@LinqLover LinqLover requested a review from codeZeilen October 10, 2022 18:21
@LinqLover LinqLover self-assigned this Oct 10, 2022
Copy link
Member

@codeZeilen codeZeilen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one minor hint for improvement. Not sure whether it is really that relevant.

Morphic/Morphic.tex Outdated Show resolved Hide resolved
@LinqLover LinqLover enabled auto-merge November 7, 2022 18:49
Morphic/Morphic.tex Outdated Show resolved Hide resolved
@LinqLover LinqLover merged commit 161f920 into hpi-swa-lab:master Nov 9, 2022
@LinqLover LinqLover mentioned this pull request Jun 27, 2023
3 tasks
@LinqLover LinqLover deleted the misc-2 branch July 10, 2023 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants