Migrate CI to GitHub Actions #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Let's begin the CI testing! 🚀
The syntax is not yet implemented as described in https://github.community/t/how-to-set-and-access-a-workflow-variable/17335/6?u=linqlover.
Simple separation of concerns ...
…le-english into github-actions
…le-english into github-actions
|
Artifacts such as PDF are only accessible when all jobs have been completed, reported here: actions/upload-artifact#181 |
Based on the excellent answer of Axel Krypton (https://tex.stackexchange.com/a/567990/221054).
|
Slack notifications are failing, opened an issue here: voxmedia/github-action-slack-notify-build#46 |
|
Message from smalltalkCI: Todo: If this problem persists, let's create an issue. |
|
Todos before merging:
|
|
Wow, nice work @LinqLover ! Do you need a detailed review of specific parts or just a general, sweeping look? :) |
Sweeping look should be enough :) |
codeZeilen
approved these changes
Apr 16, 2021
LinqLover
added a commit
that referenced
this pull request
Apr 27, 2021
codeZeilen
pushed a commit
that referenced
this pull request
Feb 28, 2022
Closes #101 and closes #97. * Migrated the entire CI pipeline from Travis CI to GitHub Actions, motivated by quota considerations, platform coolness & problems with Slack notifications as described in #97 * Decouples single CI jobs for testing, @test assertions in TEX, and screenshot/PDF generation for a faster and more fine-granular feedback on GitHub + this involves a split-up of the .smalltalk.ston files and related scripts + also extracted internal SBE tests into a separate package called SBE-Tests + implemented support for GitHub Actions CI in Makefile and SmalltalkSources * Added Slack notifications if a scheduled build (currently run once a week) fails * Provided PDF builds as artifacts on GitHub Actions instead of uploading them to Google Docs or GitHub Releases any longer * Fixed the robustize-figures mode (aka DEBUG_FIGURES) which was broken due to an update of the graphicx package and since 85b2080 (thanks again to @AxelKrypton for helping with this issue!) * Updated the documentation in the README accordingly Co-authored-by: Alessandro Sciarra <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #101 and closes #97.
This PR:
migrates the entire CI pipeline from Travis CI to GitHub Actions, motivated by quota considerations, platform coolness & problems with Slack notifications as described in Add slack notifications for build failures #97:
decouples single CI jobs for testing, @test assertions in TEX, and screenshot/PDF generation for a faster and more fine-granular feedback on GitHub (see above)
.smalltalk.stonfiles and related scriptsSBE-Testsimplements support for GitHub Actions CI in Makefile and SmalltalkSources
adds Slack notifications if a scheduled build (currently run once a week) fails:
provides PDF builds as artifacts on GitHub Actions instead of uploading them to Google Docs or GitHub Releases any longer:
fixes the
robustize-figuresmode (akaDEBUG_FIGURES) which was broken due to an update of thegraphicxpackage and since 85b2080 (thanks again to @AxelKrypton for helping with this issue!)updates the documentation in the README accordingly.
Please squash when merging.