Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BC-8763 workaround for actions/build-push-action@v6 #3561

Merged
merged 1 commit into from
Jan 20, 2025
Merged

Conversation

Loki-Afro
Copy link
Member

@Loki-Afro Loki-Afro commented Jan 20, 2025

as it appears to be incompatible with actions/download-artifact@v4 /cloudposse/github-action-matrix-outputs-read#29 (comment) see docker/build-push-action#1167

in short if one downloads an artifact that is not of type zip it might/will fail to download so most of the times this actions/toolkit#1874 might resolve the whole mess

Description

Links to Tickets or other pull requests

https://ticketsystem.dbildungscloud.de/browse/BC-8763
hpi-schul-cloud/version-aggregator#27
hpi-schul-cloud/schulcloud-server#5452
#3561
hpi-schul-cloud/nuxt-client#3506
hpi-schul-cloud/superhero-dashboard#275
hpi-schul-cloud/shd-client#38
hpi-schul-cloud/schulcloud-calendar#169
hpi-schul-cloud/antivirus_check_service#69
hpi-schul-cloud/version-aggregator#27
hpi-schul-cloud/h5p-staticfiles-server#16
hpi-schul-cloud/tldraw-client#122
hpi-schul-cloud/tldraw-server#50

Changes

Data Security

Deployment

New Repos, NPM packages or vendor scripts

Screenshots of UI changes

Approval for review

  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • All points were discussed with the ticket creator, support-team or product owner. The code upholds all quality guidelines from the PR-template.
  • DEV: Every new component is implemented having accessibility in mind (e.g. aria-label, role property)

Notice: Please remove the WIP label if the PR is ready to review, otherwise nobody will review it.

as it appears to be incompatible with actions/download-artifact@v4 /cloudposse/github-action-matrix-outputs-read#29 (comment)
see docker/build-push-action#1167

in short if one downloads an artifact that is not of type zip it might/will fail to download so most of the times this actions/toolkit#1874 might resolve the whole mess
@Loki-Afro Loki-Afro merged commit 269e480 into main Jan 20, 2025
70 checks passed
@Loki-Afro Loki-Afro deleted the bc-8763 branch January 20, 2025 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants