BC-820 - Design improvements school admin page #2845
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blazejpass
previously approved these changes
Oct 6, 2023
odalys-dataport
previously approved these changes
Oct 11, 2023
davwas
dismissed stale reviews from odalys-dataport and blazejpass
via
2cf817d
blazejpass
previously approved these changes
Oct 18, 2023
# Conflicts: # src/components/organisms/administration/SchoolPolicy.unit.ts # src/components/organisms/administration/SchoolPolicy.vue # src/components/organisms/administration/SchoolTerms.unit.ts # src/components/organisms/administration/SchoolTerms.vue
blazejpass
previously approved these changes
Oct 18, 2023
# Conflicts: # src/components/organisms/administration/GeneralSettings.vue # src/pages/administration/SchoolSettings.page.vue
blazejpass
approved these changes
Oct 19, 2023
MartinSchuhmacher
approved these changes
Oct 23, 2023
|
SonarCloud Quality Gate failed.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short Description
QA note:
Change tested on env:
https://brb-bc-820-design-improvement-admin-page.cd.dbildungscloud.dev/
https://nbc-bc-820-design-improvement-admin-page.cd.dbildungscloud.dev/
https://default-bc-820-design-improvement-admin-page.cd.dbildungscloud.dev/
No issues found. All accepted criteria from link Figma above done.
See Jira ticket: https://ticketsystem.dbildungscloud.de/browse/BC-820
Links to Ticket and related Pull-Requests
https://ticketsystem.dbildungscloud.de/browse/BC-820
Changes
Data-security
Deployment
New Repos, NPM packages or vendor scripts
Screenshots of UI changes
Checklist before merging