Skip to content
This repository has been archived by the owner on Jul 14, 2021. It is now read-only.

Commit

Permalink
👌 Update code due to review changes
Browse files Browse the repository at this point in the history
* Replace figure with div in /plugins/image
* Update CSS styling
  • Loading branch information
Florian committed Sep 20, 2018
1 parent 902ff38 commit 8600511
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 4 deletions.
2 changes: 1 addition & 1 deletion src/Editor.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ const schema = {
<div className="column" />
<div className="column is-three-quarters">
{/*<Uploader />*/}
<div style={{marginTop: '100px'}}>
<div style={{marginTop: '2rem'}}>
<HoverMenu
ref={menu => (this.hoverMenu = menu)}
value={this.state.value}
Expand Down
4 changes: 2 additions & 2 deletions src/plugins/image/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ function ImageNode(props) {
const { src, selected, ...attributes} = props

return (
<figure className={`plugin-wrapper ${selected ? 'selected' : ''}`}>
<div className={`plugin-wrapper ${selected ? 'selected' : ''}`}>
<img
src={src}
className="image"
Expand All @@ -44,7 +44,7 @@ function ImageNode(props) {
{/*<figcaption>
Figure 1: Some beautiful placeholders
</figcaption>*/}
</figure>
</div>
)
}

Expand Down
2 changes: 1 addition & 1 deletion src/plugins/section/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ const RenderSectionNode = {
if(node.type === 'section') {
const isVisible = node.data.get('isVisible')
return (
<section className="section content has-background-light" {...attributes}>
<section className="section content " {...attributes}>
{ children }
{
isFocused ? (
Expand Down
3 changes: 3 additions & 0 deletions src/plugins/section/style.css
Original file line number Diff line number Diff line change
@@ -1,6 +1,9 @@
section.section {
position: relative;
padding: 1rem;
min-height: 200px;
border: 2px solid whitesmoke;
border-radius: 4px;
}

aside.section-controls {
Expand Down

0 comments on commit 8600511

Please sign in to comment.