Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark relevant elements on map #956

Merged
merged 7 commits into from
May 11, 2023
Merged

Mark relevant elements on map #956

merged 7 commits into from
May 11, 2023

Conversation

benn02
Copy link
Contributor

@benn02 benn02 commented May 9, 2023

PR Checklist

Please make sure to fulfil the following conditions before marking this PR ready for review:

  • If this PR adds or changes features or fixes bugs, this has been added to the changelog
  • If this PR adds new actions or other ways to alter the state, test scenarios have been added

@benn02 benn02 linked an issue May 9, 2023 that may be closed by this pull request
Highlight which personnel and material belongs to the currently selected vehicle #882
Closed
@benn02
Copy link
Contributor Author

benn02 commented May 9, 2023

In addition to the linked issue, this also marks personnel and material and marks their vehicle when their popup is open

@lukasrad02 lukasrad02 self-requested a review May 11, 2023 06:48
lukasrad02
lukasrad02 requested changes May 11, 2023
View reviewed changes
Copy link
Contributor

@lukasrad02 lukasrad02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Sorry for the large number of single comments not belonging to this review. I did not had my VS Code unter control... 😅)

...p/pages/exercises/exercise/shared/exercise-map/feature-managers/personnel-feature-manager.ts Outdated Show resolved Hide resolved
...p/pages/exercises/exercise/shared/exercise-map/feature-managers/personnel-feature-manager.ts Show resolved Hide resolved
...app/pages/exercises/exercise/shared/exercise-map/feature-managers/vehicle-feature-manager.ts Outdated Show resolved Hide resolved
...app/pages/exercises/exercise/shared/exercise-map/feature-managers/vehicle-feature-manager.ts Show resolved Hide resolved
frontend/src/app/pages/exercises/exercise/shared/exercise-map/utility/ol-map-manager.ts Show resolved Hide resolved
@benn02 benn02 requested a review from lukasrad02 May 11, 2023 10:34
@benn02
Merge branch 'dev' into feature/882-highlight-which-personnel-and-mat…
b13436e 
…erial-belongs-to-the-currently-selected-vehicle
@benn02 benn02 enabled auto-merge (squash) May 11, 2023 11:05
@benn02 benn02 merged commit 631cf6a into dev May 11, 2023
@benn02 benn02 deleted the feature/882-highlight-which-personnel-and-material-belongs-to-the-currently-selected-vehicle branch May 11, 2023 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukasrad02 lukasrad02 lukasrad02 approved these changes

Assignees

@benn02 benn02

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Highlight which personnel and material belongs to the currently selected vehicle
2 participants
@benn02 @lukasrad02