CON-3166 - Removed rollback for NFS resources when creating NFS volume #437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jyotsna-lothe <[email protected]>
jlothe
requested review from
raunakkumar,
suneeth51,
pavansshanbhag,
datamattsson,
dileepds,
sijeesh and
rohit-balakrishna
as code owners
rohit-balakrishna
approved these changes
Feb 5, 2025
datamattsson
requested changes
Feb 11, 2025
There was a problem hiding this comment.
This is not working very well.
Assume a customer deploys an NFS server with more memory than is available. The Deployment will be stuck "Pending", the CSI driver is waiting indefinitely for the Deployment status to return "Running" and later create the Service if the Deployment is successful. In this state, if the user decides to delete the frontend PVC realizing the mistake of oversubscribing memory, leaves the backend "Pending" stuck forever and will eventually leave the Deployment in an unmanaged state and manual cleanup is required.
We need to be able to delete "half created" NFS deployments when they're stuck failing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review the rollback removal changes when creating NFS volume for 2.5.2 branch