Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lost NotifyDeleted()/NotifyTruncated()/NotifyModified() Signals #98

Open
arunmathew88 opened this issue Aug 1, 2016 · 0 comments
Open

Comments

@arunmathew88
Copy link
Contributor

arunmathew88 commented Aug 1, 2016

Current code misses the NotifyDeleted()/NotifyTruncated()/NotifyModified() signals if the other end of the channel is busy processing somethings else. Changing the channels [https://github.com/hpcloud/tail/blob/v1.0.0/watch/filechanges.go#L4] into buffered channel of size 1 ensures that one consolidated instance for each of these signals are retained till the other end is frees up for processing.

Possibly Fixes
Issue #94
Issue #21

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant