[ci] Fix potential github action smells #5668
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Avoid executing scheduled workflows on forks - Use 'if' for upload-artifact action - Use permissions whenever using Github Token
ver217
reviewed
Jun 12, 2024
| @@ -10,6 +10,7 @@ jobs: | |||
| matrix_preparation: | |||
| name: Prepare Container List | |||
| runs-on: ubuntu-latest | |||
| if: ${{github.event_name != 'schedule' || github.repository == 'hpcaitech-colossalai'}} | |||
There was a problem hiding this comment.
Should the repo be hpcaitech/ColossalAI? And why not run when the event name is schedule?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 Checklist before creating the PR
[doc/gemini/tensor/...]: A concise descriptionpip install pre-commit && pre-commit install🚨 Issue number
fixed: #5667
📝 What does this PR do?
Hey! 🙂
I want to contribute the following changes to your workflow:
These changes are part of a research Study at TU Delft looking at GitHub Action Smells. Find out more
💥 Checklist before requesting a review
⭐️ Do you enjoy contributing to Colossal-AI?
Tell us more if you don't enjoy contributing to Colossal-AI.