Feature/experimental string view #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The usage needs to be turned on by setting the special define LMDBXX_USE_EXPERIMENTAL_STRING_VIEW .
And adding documentation for alternative modes and type wrapper.
|
Thanks for the PR! I don't see anything wrong with the pull request itself. My only hesitation is that it makes the code slightly messier, and we have to remember to always use lmdb::string_view instead of std::string_view. Are there a lot of installations of compilers with this experimental header, but without C++17 support? |
|
Depends on the industry you are working for, sometimes you need to deal with toolchains based on FOSS landscape from 2016. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds possibility to use the C++17 variant without need of -std=c++17, virtually any GCC version from 2015 on should be sufficient.
The feature compatibility of std::experimental::string_view is queried, however there might be a gap in the first months of 2014 where the header did not exist yet. But anyhow, the impact from that is probably only a confusing error message about missing header, and also >>5y old compilers can be probably ignored.