Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Would it make sense to send a PlaybackStatus Stopped on quit? #22

Closed
timakro opened this issue Apr 14, 2019 · 4 comments
Closed

Would it make sense to send a PlaybackStatus Stopped on quit? #22

timakro opened this issue Apr 14, 2019 · 4 comments

Comments

@timakro
Copy link

timakro commented Apr 14, 2019

Not sure if this is against the spec but it would be useful when used with gpodder.
@timakro timakro changed the title Would it make sense to send a PlaybackStatus Stopped when on quit? Would it make sense to send a PlaybackStatus Stopped on quit? Apr 14, 2019
@hoyon
Copy link
Owner

hoyon commented Apr 14, 2019

Why would this behaviour be useful for gpodder? I'm not really familiar with it.

I'm not against such a feature, but I'm also not sure why it would be desired - surely the application quitting and the bus disappearing would imply playback has stopped?

@timakro
Copy link
Author

timakro commented Apr 15, 2019

gpodder is tracking the position you were last listening. Like this it can only tell when you pause the playback before quitting.

@jonath92
Copy link

I also would like to see this. I am using the plugin for the Linux Mint Radio Applet and this would make my code much cleaner.

hoyon added a commit that referenced this issue Mar 5, 2022
@hoyon
Emit Stopped signal on exit
c688351 
Fixes: #61, #22
@hoyon
Copy link
Owner

hoyon commented Mar 5, 2022

Fixed in c688351

@hoyon hoyon closed this as completed Mar 5, 2022
bmwiedemann pushed a commit to bmwiedemann/openSUSE that referenced this issue Jun 18, 2022
@bmwiedemann
Update mpv-mpris to version 0.8.1 / rev 3 via SR 983511
5e4d378 
https://build.opensuse.org/request/show/983511
by user mia + dimstar_suse
- Update to 0.8.1
  * Fix Unknown Artist for YouTube videos
    #gh/hoyon/mpv-mpris#76
  * Emit signal for fullscreen event
    #gh/hoyon/mpv-mpris#78

- Update to 0.7.1
  * Add test suite
  * Emit Stopped Signal on exit.
    #gh/hoyon/mpv-mpris#61
    #gh/hoyon/mpv-mpris#22
  * Set xesam:artist to channel name for YouTube videos.
    #gh/hoyon/mpv-mpris#50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@hoyon @timakro @jonath92