Typescript Declaration #953
Conversation
* d.ts * Conversation * slack * slack * cisco spark * storage & logger * remove others * example slack * facebook * studio * twilio * bot framework * rm lib/_Botkit.d.ts * package.json
| on(event: string, cb: HearsCallback<S, M, B>): this; | ||
| setupWebserver(port: number | string, cb: (err: Error, webserver: any) => void): this; | ||
| spawn(config?: S, cb?: (worker: B) => void): B; | ||
| startTicking(): void; |
|
Thanks, I don't get any type errors anymore, but I get a runtime error Compiled code looks like this: var botkit_1 = require("botkit");
var bot_options = {
json_file_store: __dirname + '/../.data/db/'
};
// Create the Botkit controller, which controls all instances of the bot.
var controller = botkit_1.default.consolebot(bot_options); |
| type SlackWebAPIMethod = (data: any, cb: (err: Error, response: any) => void) => void; | ||
| } | ||
|
|
||
| export = botkit; |
There was a problem hiding this comment.
@Naktibalda Thank you for your review.
It is my mistake.
5951c74
Please import the module as below:
import Botkit = require('botkit');
|
Thanks, it works now. Could you add at least one example file converted to Typescript? I was going to ask you to add dtslint to CI configuration, but I just noticed that botkit has no CI. |
Sure. |
|
I expected to see more types, but it is okay. @benbrown I think that this PR is good to merge. |
|
nice work! |
Revised version of #494.
I checked that this declaration file passed the examples on https://github.com/howdyai/botkit/tree/master/examples.