This repository has been archived by the owner on Sep 20, 2024. It is now read-only.
Change ping to an explicit message rather than ws protocol frame #808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this PR is redundant now, so i'll clean up house a bit :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current recommendation from Slack is to use a message to ping the websocket servers in addition to the protocol specific ping frames (the ws library can handle this all on its own and there's no need for code). Thus the ping code here was redundant since it was sending the same type of ping the server would have already been sending and the botkit client would have already been ponging. With this change, I also hope to resolve possible issues related to pings being an unmasked message and people getting abnormal terminations after that message was sent.