This repository has been archived by the owner on Sep 20, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added two tests for identity Shutdown the controller after each test to allow script to exit.
jscs formatting changes
Change tests for falsy to null or undefined.
Add data not present for get and delete Run each test with a new data storage directory
Use workers for calls to API rather than the controller.
benbrown
approved these changes
Oct 19, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move all tests under a single directory structure.
Add an npm command for running the legacy tests.
Fix issues with the legacy Facebook tests not exiting.
Fix issues with the slackbot worker tests not exiting.
Add two legacy Facebook tests.
Update the simple storage unit tests for Jest.
Fix a number of spelling errors.
Fix a bug with Facebook postback message type being overwritten.
Fix a bug in Teams where it would not create conversations due to a typo in the method name.