Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

Extend replyWithTyping() with typingDelay parameter. #1303

Closed
wants to merge 7 commits into from
Closed

Extend replyWithTyping() with typingDelay parameter. #1303

wants to merge 7 commits into from

Conversation

imjul1an
Copy link
Contributor

@imjul1an imjul1an commented Mar 26, 2018 •
edited
Loading

This PR contains:

  • Facebook: Extended replyWithTyping function, so it accepts typingDelay parameter.
  • Slack: Extended replyWithTyping function, so it accepts typingDelay parameter.
  • Web: Refactor replyWithTyping function, so it is consistent with Facebook's and Slack's replyWithTyping implementation.
  • Add ltx dependency, which was missing in package.json. Without it, npm run test failing.
  • Update documentation, so it is clear how to use typingDelay across platforms.

Close #1286

@imjul1an
Copy link
Contributor Author

Please review this PR @ouadie-lahdioui @peterswimm

@imjul1an imjul1an changed the title Add typingDelay for Facebook replyWithtyping Add typingDelay for Facebook replyWithTyping Mar 26, 2018
@imjul1an imjul1an changed the title Add typingDelay for Facebook replyWithTyping Add typingDelay for Facebook replyWithTyping (issue #1286) Mar 26, 2018
@imjul1an imjul1an changed the title Add typingDelay for Facebook replyWithTyping (issue #1286) Add typingDelay for Facebook replyWithTyping. Mar 26, 2018
@imjul1an imjul1an changed the title Add typingDelay for Facebook replyWithTyping. Add typingDelay param for Facebook replyWithTyping(). Mar 26, 2018
@imjul1an imjul1an changed the title Add typingDelay param for Facebook replyWithTyping(). Add typingDelay param for Facebook replyWithTyping() Mar 26, 2018
@imjul1an imjul1an changed the title Add typingDelay param for Facebook replyWithTyping() Extend replyWithTyping() with typingDelay parameter. Mar 26, 2018
@imjul1an
Copy link
Contributor Author

imjul1an commented Mar 27, 2018 •
edited
Loading

@peterswimm I've updated documentation for Facebook and Web, it is still missing for Slack. But I haven't found a section where I can add it. Could you please review it? If it's okay then feel free to merge this PR, otherwise, let me know what should I change.

benbrown
benbrown reviewed Jul 9, 2018
View reviewed changes
lib/Web.js

if (typeof message === 'string') {
textLength = message.length;
} else if (messag.text) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is a typo here in the variable name

@stale
Copy link

stale bot commented Oct 22, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Oct 22, 2018
@stale stale bot closed this Oct 30, 2018
@snyk-bot snyk-bot mentioned this pull request Aug 9, 2020
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@benbrown benbrown benbrown left review comments

@ouadie-lahdioui ouadie-lahdioui ouadie-lahdioui approved these changes

Assignees
No one assigned
Labels
enhancement stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@imjul1an @benbrown @ouadie-lahdioui @peterswimm