Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: supports multiple compose files #8

Merged
merged 1 commit into from
Oct 5, 2022
Merged

feat: supports multiple compose files #8

merged 1 commit into from
Oct 5, 2022

Conversation

neilime
Copy link
Collaborator

@neilime neilime commented Sep 30, 2022

compose-file

Can be a list of files:

compose-file: |
  docker-compose.yml
  docker-compose.ci.yml

@isbang
Copy link
Collaborator

isbang commented Oct 2, 2022

Thank you for your contribution! May I ask when this feature is needed? And please fix ci test.

@isbang isbang self-requested a review October 2, 2022 14:16
@neilime
Copy link
Collaborator Author

neilime commented Oct 2, 2022

Thank you for your contribution! May I ask when this feature is needed? And please fix ci test.

It is common to manage several docker-compose files depending the context of usage:

  • docker-compose.base.yml: describe services and common settings
  • docker-compose.dev.yml: add extra configuration for development purpose
  • docker-compose.ci.yml: add extra configuration for CI purpose

So for running services in CI mode, we need to run docker-compose up -f docker-compose.base.yml -f docker-compose.ci.yml up

Copy link
Collaborator

@isbang isbang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Do you want to merge your self?

@neilime
Copy link
Collaborator Author

neilime commented Oct 5, 2022

LGTM

Do you want to merge your self?

I cannot merge, I let you do it

@isbang isbang merged commit 234ccc8 into hoverkraft-tech:main Oct 5, 2022
@neilime neilime deleted the feat/suuports-multiple-compose-files branch October 5, 2022 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants