Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade: docker-compose to v2 #30

Merged
merged 3 commits into from
Jul 23, 2023
Merged

Conversation

9bany
Copy link
Contributor

@9bany 9bany commented Jul 14, 2023

First, thank you for your work @isbang . This is an amazing tool.

I think we need to upgrade the docker-compose version to v2 because v1 is incompatible.

resolve #20

9bany and others added 2 commits July 14, 2023 09:01
- user docker compose instead
Copy link
Collaborator

@isbang isbang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution. I was barely able to maintaining this project, but now I think I should to focus on the transition to v2.

package.json Outdated Show resolved Hide resolved
@isbang
Copy link
Collaborator

isbang commented Jul 15, 2023

Please run npm run format before pushing your commit ;)

@9bany
Copy link
Contributor Author

9bany commented Jul 15, 2023

thanks for your feedbacks @isbang
Just done, please review again

Copy link
Collaborator

@isbang isbang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution.

@isbang isbang merged commit 0645acf into hoverkraft-tech:main Jul 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

consider detecting / supporting docker compose (with space)
2 participants