Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Kraken] set nb_nearest_vertices to -1 #3039

Merged
merged 2 commits into from
Nov 25, 2019
Merged

[Kraken] set nb_nearest_vertices to -1 #3039

merged 2 commits into from
Nov 25, 2019

Conversation

xlqian
Copy link
Member

@xlqian xlqian commented Nov 19, 2019

This little is due to these tickets: https://jira.kisio.org/browse/NAVITIAII-2950 https://jira.kisio.org/browse/NAVITIAII-2956

The projection was wrong because this number is big enough. In order not to impact the performance, we use 50.

kinnou02
kinnou02 reviewed Nov 19, 2019
View reviewed changes
Copy link
Contributor

@kinnou02 kinnou02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So next time if we have a longer street we set it to 100?

@xlqian
Copy link
Member Author

xlqian commented Nov 19, 2019 •
edited
Loading

@kinnou02 I set this magic number to -1 so that flann will find all nodes inside 500 meters

for walking and bike mode, the change didn't impact a lot the performance during my benchmark. But it did impact like 10% for car mode

@xlqian xlqian changed the title set nb_nearest_vertices to 50 [Kraken] set nb_nearest_vertices to 50 Nov 19, 2019
@xlqian xlqian force-pushed the change_nb_nearest_vertices_for_projection branch from 20ee89e to 2572595 Compare November 19, 2019 14:28
@xlqian xlqian changed the title [Kraken] set nb_nearest_vertices to 50 [Kraken] set nb_nearest_vertices to -1 Nov 19, 2019
@xlqian
Copy link
Member Author

xlqian commented Nov 20, 2019

Artemis OK!
https://ci.navitia.io/job/custom_Artemis/13/

kinnou02
kinnou02 approved these changes Nov 20, 2019
View reviewed changes
Copy link
Contributor

@kinnou02 kinnou02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be good

pbougue
pbougue reviewed Nov 20, 2019
View reviewed changes
Copy link
Contributor

@pbougue pbougue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Looks like your artemis' test was without IdFM, so I think it's worth launching for IdFM too.

This is a fine change, and the trade-off on perfs vs. quality is OK 👍

@xlqian xlqian merged commit ed565e0 into hove-io:dev Nov 25, 2019
@eturck eturck mentioned this pull request Jan 28, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AurelienLP AurelienLP AurelienLP approved these changes

@pbougue pbougue pbougue approved these changes

@kinnou02 kinnou02 kinnou02 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@xlqian @kinnou02 @pbougue @AurelienLP