Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#256 When use the block mode, not all workspaces are blocked in Mac OS X #257

Closed
wants to merge 1 commit into from

Conversation

mhewedy
Copy link

@mhewedy mhewedy commented Jun 29, 2018

Issue: #256

Requirements

  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • issue was opened to discuss proposed changes before starting implementation.
  • during development, node version specified in package.json was used.
  • package versions were not changed.
  • app version number was not changed.
  • all new code has tests to ensure against regressions.
  • npm run lint reports no offenses.
  • npm run test is error-free.
  • README and CHANGELOG were updated accordingly.

Description of the Change

Verification Process

Other information

@codecov
Copy link

codecov bot commented Jun 29, 2018

Codecov Report

Merging #257 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #257   +/-   ##
=======================================
  Coverage   84.55%   84.55%           
=======================================
  Files           7        7           
  Lines         123      123           
  Branches       17       17           
=======================================
  Hits          104      104           
  Misses         19       19

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c9d960e...4be15d6. Read the comment docs.

@hovancik
Copy link
Owner

could not push to your repo so closed the issue in #306

@hovancik hovancik closed this Oct 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants