You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
hovancik
merged 4 commits into
hovancik:trunk
from
lkrms:feature/schedule-next-breakFeb 21, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
issue was opened to discuss proposed changes before starting implementation. It is important do discuss changes before implementing them (Why should we add it? How should it work? How should it look? Where will it be? ...).
during development, node version specified in package.json was used (ie using nvm).
package versions and package-lock.json were not changed (npm install --no-save).
app version number was not changed.
all new code has tests to ensure against regressions.
npm run lint reports no offenses.
npm run test is error-free.
README and CHANGELOG were updated accordingly.
after PR is approved, all commits in it are squashed
Description of the Change
In the Command class:
Add new --wait option to commands mini and long.
Add waitToMs method to utilise the existing interval parser (parseDuration) from main.js when processing CLI options.
BreaksPlanner:
Rename skipToMicrobreak to scheduleMicrobreak and modify it slightly, adding a new skipToMicrobreak function that simply calls scheduleMicrobreak(100)
Ditto for skipToBreak and scheduleBreak
Fix a few minor typos and inconsistencies in logged output.
`Command`:
- Add new `--wait` option to commands `mini` and `long`
- Add `waitToMs` method to utilise the existing interval parser,
`parseDuration`
`BreaksPlanner`:
- Split `skipToMicrobreak` to add `scheduleMicrobreak`
- Same for `skipToBreak`, `scheduleBreak`
- Fix typos and inconsistencies in logged output
- breaksPlanner.js: remove separate `scheduleMicrobreak` and
`scheduleBreak` functions
- main.js:
- Give `ms` variables more descriptive names
- Remove default `delay` from `skipToMicrobreak` and `skipToBreak`
- commands.js: add an example
Thanks for the changes! I've tried locally and all seems fine :) Could you please update the CHANGELOG and squash?
I'm sorry I didn't get to this sooner. FOSS contribution time has been difficult to find over the last couple of weeks, but I was happy to do it. Thank you for merging. 🙏🏻
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: closes #1091
Requirements
nodeversion specified inpackage.jsonwas used (ie using nvm).npm install --no-save).npm run lintreports no offenses.npm run testis error-free.Description of the Change
In the
Commandclass:--waitoption to commandsminiandlong.waitToMsmethod to utilise the existing interval parser (parseDuration) frommain.jswhen processing CLI options.BreaksPlanner:Rename
skipToMicrobreaktoscheduleMicrobreakand modify it slightly, adding a newskipToMicrobreakfunction that simply callsscheduleMicrobreak(100)Ditto for
skipToBreakandscheduleBreakFix a few minor typos and inconsistencies in logged output.