Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: 2022-10-06 release (#504) #505

Merged
merged 1 commit into from
Oct 6, 2022
Merged

chore: 2022-10-06 release (#504) #505

merged 1 commit into from
Oct 6, 2022

Conversation

ludtkemorgan
Copy link
Collaborator

  • 2938/card component (2938/card component bloom-housing/bloom#3043)

  • feat: first pass at a generic Card component

  • feat: Finalize Card stories, Detroit style, responsive padding

  • feat: add more stories and docs for Card

  • feat: add CardHeadingGroup component

  • docs: add lots of new details on Card

  • test: add unit test for Card

BREAKING CHANGE: Renamed exported interfaces in ListingCard so as to not conflict with Card and other components

  • Fix code style issues with Prettier

  • feat: split HeadingGroup out to its own separate component

  • fix: simplify stories and styling for Card and HeadingGroup

  • remove: prototype "slotted" card component

  • test: fix the incorrect component name in Card

Co-authored-by: Lint Action [email protected]

BREAKING CHANGE: the different style types you can pass to the heading component have individually been renamed to fit the design system, as well as the prop to pass them in

Co-authored-by: Jared White [email protected]
Co-authored-by: Lint Action [email protected]
Co-authored-by: Emily Jablonski [email protected]

Pull Request Template

Issue Overview

This PR addresses #issue

  • This change addresses the issue in full
  • This change addresses only certain aspects of the issue
  • This change is a dependency for another issue
  • This change has a dependency from another issue

Description

Please include a summary of the change and which issue(s) is addressed. Please also include relevant motivation and context. List any dependencies that are required for this change.

How Can This Be Tested/Reviewed?

Provide instructions so we can review.

Describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration.

Checklist:

  • My code follows the style guidelines of this project
  • I have added QA notes to the issue with applicable URLs
  • I have performed a self-review of my own code
  • I have reviewed the changes in a desktop view
  • I have reviewed the changes in a mobile view
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have assigned reviewers
  • I have run yarn generate:client and/or created a migration if I made backend changes that require them
  • I have exported any new pieces added to ui-components
  • My commit message(s) is/are polished, and any breaking changes are indicated in the message and are well-described
  • Commits made across packages purposefully have the same commit message/version change, else are separated into different commits

Reviewer Notes:

Steps to review a PR:

  • Read and understand the issue, and ensure the author has added QA notes
  • Review the code itself from a style point of view
  • Pull the changes down locally and test that the acceptance criteria is met
  • Also review the acceptance criteria on the Netlify deploy preview (noting that these do not yet include any backend changes made in the PR)
  • Either explicitly ask a clarifying question, request changes, or approve the PR if there are small remaining changes but the PR is otherwise good to go

On Merge:

If you have one commit and message, squash. If you need each message to be applied, rebase and merge.

* 2938/card component (bloom-housing#3043)

* feat: first pass at a generic Card component

* feat: Finalize Card stories, Detroit style, responsive padding

* feat: add more stories and docs for Card

* feat: add CardHeadingGroup component

* docs: add lots of new details on Card

* test: add unit test for Card

BREAKING CHANGE: Renamed exported interfaces in ListingCard so as to not conflict with Card and other components

* Fix code style issues with Prettier

* feat: split HeadingGroup out to its own separate component

* fix: simplify stories and styling for Card and HeadingGroup

* remove: prototype "slotted" card component

* test: fix the incorrect component name in Card

Co-authored-by: Lint Action <[email protected]>

* fix: make pill style on listing card optional (bloom-housing#3088)

* refactor: organize design system text styles (bloom-housing#3055)

BREAKING CHANGE: the different style types you can pass to the heading component have individually been renamed to fit the design system, as well as the prop to pass them in

* fix: individual application link in applications table (bloom-housing#3125)

* fix: update copy on total number of duplicate sets (bloom-housing#3119)

* fix: rename text style class for consistency (bloom-housing#3122)

Co-authored-by: Jared White <[email protected]>
Co-authored-by: Lint Action <[email protected]>
Co-authored-by: Emily Jablonski <[email protected]>
@ludtkemorgan ludtkemorgan merged commit e8c9f11 into main Oct 6, 2022
ludtkemorgan added a commit that referenced this pull request Oct 18, 2022
ludtkemorgan added a commit that referenced this pull request Oct 18, 2022
ludtkemorgan added a commit that referenced this pull request Oct 18, 2022
* 2938/card component (bloom-housing#3043)

* feat: first pass at a generic Card component

* feat: Finalize Card stories, Detroit style, responsive padding

* feat: add more stories and docs for Card

* feat: add CardHeadingGroup component

* docs: add lots of new details on Card

* test: add unit test for Card

BREAKING CHANGE: Renamed exported interfaces in ListingCard so as to not conflict with Card and other components

* Fix code style issues with Prettier

* feat: split HeadingGroup out to its own separate component

* fix: simplify stories and styling for Card and HeadingGroup

* remove: prototype "slotted" card component

* test: fix the incorrect component name in Card

Co-authored-by: Lint Action <[email protected]>

* fix: make pill style on listing card optional (bloom-housing#3088)

* refactor: organize design system text styles (bloom-housing#3055)

BREAKING CHANGE: the different style types you can pass to the heading component have individually been renamed to fit the design system, as well as the prop to pass them in

* fix: individual application link in applications table (bloom-housing#3125)

* fix: update copy on total number of duplicate sets (bloom-housing#3119)

* fix: rename text style class for consistency (bloom-housing#3122)

Co-authored-by: Jared White <[email protected]>
Co-authored-by: Lint Action <[email protected]>
Co-authored-by: Emily Jablonski <[email protected]>

Co-authored-by: Jared White <[email protected]>
Co-authored-by: Lint Action <[email protected]>
Co-authored-by: Emily Jablonski <[email protected]>
ludtkemorgan added a commit that referenced this pull request Oct 18, 2022
* 2938/card component (bloom-housing#3043)

* feat: first pass at a generic Card component

* feat: Finalize Card stories, Detroit style, responsive padding

* feat: add more stories and docs for Card

* feat: add CardHeadingGroup component

* docs: add lots of new details on Card

* test: add unit test for Card

BREAKING CHANGE: Renamed exported interfaces in ListingCard so as to not conflict with Card and other components

* Fix code style issues with Prettier

* feat: split HeadingGroup out to its own separate component

* fix: simplify stories and styling for Card and HeadingGroup

* remove: prototype "slotted" card component

* test: fix the incorrect component name in Card

Co-authored-by: Lint Action <[email protected]>

* fix: make pill style on listing card optional (bloom-housing#3088)

* refactor: organize design system text styles (bloom-housing#3055)

BREAKING CHANGE: the different style types you can pass to the heading component have individually been renamed to fit the design system, as well as the prop to pass them in

* fix: individual application link in applications table (bloom-housing#3125)

* fix: update copy on total number of duplicate sets (bloom-housing#3119)

* fix: rename text style class for consistency (bloom-housing#3122)

Co-authored-by: Jared White <[email protected]>
Co-authored-by: Lint Action <[email protected]>
Co-authored-by: Emily Jablonski <[email protected]>

Co-authored-by: Jared White <[email protected]>
Co-authored-by: Lint Action <[email protected]>
Co-authored-by: Emily Jablonski <[email protected]>
ludtkemorgan added a commit that referenced this pull request Oct 19, 2022
* 2938/card component (bloom-housing#3043)

* feat: first pass at a generic Card component

* feat: Finalize Card stories, Detroit style, responsive padding

* feat: add more stories and docs for Card

* feat: add CardHeadingGroup component

* docs: add lots of new details on Card

* test: add unit test for Card

BREAKING CHANGE: Renamed exported interfaces in ListingCard so as to not conflict with Card and other components

* Fix code style issues with Prettier

* feat: split HeadingGroup out to its own separate component

* fix: simplify stories and styling for Card and HeadingGroup

* remove: prototype "slotted" card component

* test: fix the incorrect component name in Card

Co-authored-by: Lint Action <[email protected]>

* fix: make pill style on listing card optional (bloom-housing#3088)

* refactor: organize design system text styles (bloom-housing#3055)

BREAKING CHANGE: the different style types you can pass to the heading component have individually been renamed to fit the design system, as well as the prop to pass them in

* fix: individual application link in applications table (bloom-housing#3125)

* fix: update copy on total number of duplicate sets (bloom-housing#3119)

* fix: rename text style class for consistency (bloom-housing#3122)

Co-authored-by: Jared White <[email protected]>
Co-authored-by: Lint Action <[email protected]>
Co-authored-by: Emily Jablonski <[email protected]>

Co-authored-by: Jared White <[email protected]>
Co-authored-by: Lint Action <[email protected]>
Co-authored-by: Emily Jablonski <[email protected]>
ludtkemorgan added a commit that referenced this pull request Oct 19, 2022
* 2938/card component (bloom-housing#3043)

* feat: first pass at a generic Card component

* feat: Finalize Card stories, Detroit style, responsive padding

* feat: add more stories and docs for Card

* feat: add CardHeadingGroup component

* docs: add lots of new details on Card

* test: add unit test for Card

BREAKING CHANGE: Renamed exported interfaces in ListingCard so as to not conflict with Card and other components

* Fix code style issues with Prettier

* feat: split HeadingGroup out to its own separate component

* fix: simplify stories and styling for Card and HeadingGroup

* remove: prototype "slotted" card component

* test: fix the incorrect component name in Card

Co-authored-by: Lint Action <[email protected]>

* fix: make pill style on listing card optional (bloom-housing#3088)

* refactor: organize design system text styles (bloom-housing#3055)

BREAKING CHANGE: the different style types you can pass to the heading component have individually been renamed to fit the design system, as well as the prop to pass them in

* fix: individual application link in applications table (bloom-housing#3125)

* fix: update copy on total number of duplicate sets (bloom-housing#3119)

* fix: rename text style class for consistency (bloom-housing#3122)

Co-authored-by: Jared White <[email protected]>
Co-authored-by: Lint Action <[email protected]>
Co-authored-by: Emily Jablonski <[email protected]>

Co-authored-by: Jared White <[email protected]>
Co-authored-by: Lint Action <[email protected]>
Co-authored-by: Emily Jablonski <[email protected]>
ludtkemorgan added a commit that referenced this pull request Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant