forked from bloom-housing/bloom
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: 2022-10-06 release (#504) #505
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* 2938/card component (bloom-housing#3043) * feat: first pass at a generic Card component * feat: Finalize Card stories, Detroit style, responsive padding * feat: add more stories and docs for Card * feat: add CardHeadingGroup component * docs: add lots of new details on Card * test: add unit test for Card BREAKING CHANGE: Renamed exported interfaces in ListingCard so as to not conflict with Card and other components * Fix code style issues with Prettier * feat: split HeadingGroup out to its own separate component * fix: simplify stories and styling for Card and HeadingGroup * remove: prototype "slotted" card component * test: fix the incorrect component name in Card Co-authored-by: Lint Action <[email protected]> * fix: make pill style on listing card optional (bloom-housing#3088) * refactor: organize design system text styles (bloom-housing#3055) BREAKING CHANGE: the different style types you can pass to the heading component have individually been renamed to fit the design system, as well as the prop to pass them in * fix: individual application link in applications table (bloom-housing#3125) * fix: update copy on total number of duplicate sets (bloom-housing#3119) * fix: rename text style class for consistency (bloom-housing#3122) Co-authored-by: Jared White <[email protected]> Co-authored-by: Lint Action <[email protected]> Co-authored-by: Emily Jablonski <[email protected]>
ludtkemorgan
added a commit
that referenced
this pull request
Oct 18, 2022
ludtkemorgan
added a commit
that referenced
this pull request
Oct 18, 2022
ludtkemorgan
added a commit
that referenced
this pull request
Oct 18, 2022
* 2938/card component (bloom-housing#3043) * feat: first pass at a generic Card component * feat: Finalize Card stories, Detroit style, responsive padding * feat: add more stories and docs for Card * feat: add CardHeadingGroup component * docs: add lots of new details on Card * test: add unit test for Card BREAKING CHANGE: Renamed exported interfaces in ListingCard so as to not conflict with Card and other components * Fix code style issues with Prettier * feat: split HeadingGroup out to its own separate component * fix: simplify stories and styling for Card and HeadingGroup * remove: prototype "slotted" card component * test: fix the incorrect component name in Card Co-authored-by: Lint Action <[email protected]> * fix: make pill style on listing card optional (bloom-housing#3088) * refactor: organize design system text styles (bloom-housing#3055) BREAKING CHANGE: the different style types you can pass to the heading component have individually been renamed to fit the design system, as well as the prop to pass them in * fix: individual application link in applications table (bloom-housing#3125) * fix: update copy on total number of duplicate sets (bloom-housing#3119) * fix: rename text style class for consistency (bloom-housing#3122) Co-authored-by: Jared White <[email protected]> Co-authored-by: Lint Action <[email protected]> Co-authored-by: Emily Jablonski <[email protected]> Co-authored-by: Jared White <[email protected]> Co-authored-by: Lint Action <[email protected]> Co-authored-by: Emily Jablonski <[email protected]>
ludtkemorgan
added a commit
that referenced
this pull request
Oct 18, 2022
* 2938/card component (bloom-housing#3043) * feat: first pass at a generic Card component * feat: Finalize Card stories, Detroit style, responsive padding * feat: add more stories and docs for Card * feat: add CardHeadingGroup component * docs: add lots of new details on Card * test: add unit test for Card BREAKING CHANGE: Renamed exported interfaces in ListingCard so as to not conflict with Card and other components * Fix code style issues with Prettier * feat: split HeadingGroup out to its own separate component * fix: simplify stories and styling for Card and HeadingGroup * remove: prototype "slotted" card component * test: fix the incorrect component name in Card Co-authored-by: Lint Action <[email protected]> * fix: make pill style on listing card optional (bloom-housing#3088) * refactor: organize design system text styles (bloom-housing#3055) BREAKING CHANGE: the different style types you can pass to the heading component have individually been renamed to fit the design system, as well as the prop to pass them in * fix: individual application link in applications table (bloom-housing#3125) * fix: update copy on total number of duplicate sets (bloom-housing#3119) * fix: rename text style class for consistency (bloom-housing#3122) Co-authored-by: Jared White <[email protected]> Co-authored-by: Lint Action <[email protected]> Co-authored-by: Emily Jablonski <[email protected]> Co-authored-by: Jared White <[email protected]> Co-authored-by: Lint Action <[email protected]> Co-authored-by: Emily Jablonski <[email protected]>
ludtkemorgan
added a commit
that referenced
this pull request
Oct 19, 2022
* 2938/card component (bloom-housing#3043) * feat: first pass at a generic Card component * feat: Finalize Card stories, Detroit style, responsive padding * feat: add more stories and docs for Card * feat: add CardHeadingGroup component * docs: add lots of new details on Card * test: add unit test for Card BREAKING CHANGE: Renamed exported interfaces in ListingCard so as to not conflict with Card and other components * Fix code style issues with Prettier * feat: split HeadingGroup out to its own separate component * fix: simplify stories and styling for Card and HeadingGroup * remove: prototype "slotted" card component * test: fix the incorrect component name in Card Co-authored-by: Lint Action <[email protected]> * fix: make pill style on listing card optional (bloom-housing#3088) * refactor: organize design system text styles (bloom-housing#3055) BREAKING CHANGE: the different style types you can pass to the heading component have individually been renamed to fit the design system, as well as the prop to pass them in * fix: individual application link in applications table (bloom-housing#3125) * fix: update copy on total number of duplicate sets (bloom-housing#3119) * fix: rename text style class for consistency (bloom-housing#3122) Co-authored-by: Jared White <[email protected]> Co-authored-by: Lint Action <[email protected]> Co-authored-by: Emily Jablonski <[email protected]> Co-authored-by: Jared White <[email protected]> Co-authored-by: Lint Action <[email protected]> Co-authored-by: Emily Jablonski <[email protected]>
ludtkemorgan
added a commit
that referenced
this pull request
Oct 19, 2022
* 2938/card component (bloom-housing#3043) * feat: first pass at a generic Card component * feat: Finalize Card stories, Detroit style, responsive padding * feat: add more stories and docs for Card * feat: add CardHeadingGroup component * docs: add lots of new details on Card * test: add unit test for Card BREAKING CHANGE: Renamed exported interfaces in ListingCard so as to not conflict with Card and other components * Fix code style issues with Prettier * feat: split HeadingGroup out to its own separate component * fix: simplify stories and styling for Card and HeadingGroup * remove: prototype "slotted" card component * test: fix the incorrect component name in Card Co-authored-by: Lint Action <[email protected]> * fix: make pill style on listing card optional (bloom-housing#3088) * refactor: organize design system text styles (bloom-housing#3055) BREAKING CHANGE: the different style types you can pass to the heading component have individually been renamed to fit the design system, as well as the prop to pass them in * fix: individual application link in applications table (bloom-housing#3125) * fix: update copy on total number of duplicate sets (bloom-housing#3119) * fix: rename text style class for consistency (bloom-housing#3122) Co-authored-by: Jared White <[email protected]> Co-authored-by: Lint Action <[email protected]> Co-authored-by: Emily Jablonski <[email protected]> Co-authored-by: Jared White <[email protected]> Co-authored-by: Lint Action <[email protected]> Co-authored-by: Emily Jablonski <[email protected]>
ludtkemorgan
added a commit
that referenced
this pull request
Oct 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2938/card component (2938/card component bloom-housing/bloom#3043)
feat: first pass at a generic Card component
feat: Finalize Card stories, Detroit style, responsive padding
feat: add more stories and docs for Card
feat: add CardHeadingGroup component
docs: add lots of new details on Card
test: add unit test for Card
BREAKING CHANGE: Renamed exported interfaces in ListingCard so as to not conflict with Card and other components
Fix code style issues with Prettier
feat: split HeadingGroup out to its own separate component
fix: simplify stories and styling for Card and HeadingGroup
remove: prototype "slotted" card component
test: fix the incorrect component name in Card
Co-authored-by: Lint Action [email protected]
fix: make pill style on listing card optional (fix: make pill style on listing card optional bloom-housing/bloom#3088)
refactor: organize design system text styles (refactor: organize design system text styles bloom-housing/bloom#3055)
BREAKING CHANGE: the different style types you can pass to the heading component have individually been renamed to fit the design system, as well as the prop to pass them in
fix: individual application link in applications table (fix: individual application link in applications table bloom-housing/bloom#3125)
fix: update copy on total number of duplicate sets (fix: update copy on total number of duplicate sets bloom-housing/bloom#3119)
fix: rename text style class for consistency (fix: rename text style class for consistency bloom-housing/bloom#3122)
Co-authored-by: Jared White [email protected]
Co-authored-by: Lint Action [email protected]
Co-authored-by: Emily Jablonski [email protected]
Pull Request Template
Issue Overview
This PR addresses #issue
Description
Please include a summary of the change and which issue(s) is addressed. Please also include relevant motivation and context. List any dependencies that are required for this change.
How Can This Be Tested/Reviewed?
Provide instructions so we can review.
Describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration.
Checklist:
yarn generate:client
and/or created a migration if I made backend changes that require themReviewer Notes:
Steps to review a PR:
On Merge:
If you have one commit and message, squash. If you need each message to be applied, rebase and merge.