Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put test 'args' at the end of the test command #30

Closed
wants to merge 1 commit into from

Conversation

donatello
Copy link
Contributor

For test command, there can be arguments passed to the test binary like -- --ignored or -- --test-threads=1. For these cases to work properly, the args parameter needs to be added to the end of the 'test' command.

For test command, there can be arguments passed to the test binary like
`-- --ignored` or `-- --test-threads=1`. For these cases to work
properly, the `args` parameter needs to be added to the end of the
'test' command.
@donatello
Copy link
Contributor Author

This is based on #12 and completes it by adding a test.

@autarch
Copy link
Member

autarch commented Nov 11, 2024

Hi, thanks for your PR! I'm pretty finicky about my projects (see this blog post for details), so I rarely merge a PR as-is. I can move forward on your PR in one of two ways:

  1. I check it out locally, fiddle with it as needed, merge it locally, and simply close this PR. This will preserve at least one commit with your name on it, but the PR will show up as closed in your GitHub stats.
  2. If you enable me to push directly to your fork, I can do my fiddling, then force push to your fork and merge the resulting PR. Again, this will preserve at least one commit with your name on it, but you also get credit for the PR merge in your GitHub stats. The only downside is that I will be force pushing directly to your fork.

Please let me know which approach you'd prefer. If I don't hear from you before I get around to working on this PR I'll go with option 1.

Thanks again for your contribution!

@autarch
Copy link
Member

autarch commented Nov 17, 2024

I merged this from the CLI.

@autarch autarch closed this Nov 17, 2024
@autarch
Copy link
Member

autarch commented Nov 17, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants