PageSnapshot: reduce cloning loop iterations #669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follow-up to hotwired#666 Following [a suggestion][] provided by review of hotwired#666, this commit remove unnecessary loops when cloning a page's form controls to be cached by a snapshot. [a suggestion]: hotwired#666 (comment)
tleish
reviewed
Aug 5, 2022
| } | ||
| const clone = clonedSelectElements[index] | ||
| for (const option of clone.selectedOptions) option.selected = false | ||
| for (const option of source.selectedOptions) clone.options[option.index].selected = true |
There was a problem hiding this comment.
Yes, this change is also significantly faster than the change I suggested in the previous PR.
Overall in the HTML page I tested:
- original: 0.5ms to 1.0ms
- updated: 0.07ms to 0.1ms
🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #666
Following a suggestion provided by review of #666, this commit
remove unnecessary loops when cloning a page's form controls to be
cached by a snapshot.