Resolve Frame Visit caching issue #644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes hotwired#643 First, rename the `FrameRendererDelegate.frameExtracted` callback method to `willRenderFrame`, then pass along both the _current_ frame and the _new_ frame as arguments. Next, in the `FrameController.willRenderFrame` callback, assign the `previousFrameElement` property (used elsewhere in the `visitCachedSnapshot` callback) to contain the contents of the _current_ frame, instead of the _new_ frame.
manuelpuyol
approved these changes
Jul 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #643
First, rename the
FrameRendererDelegate.frameExtractedcallback methodto
willRenderFrame, then pass along both the current frame and thenew frame as arguments.
Next, in the
FrameController.willRenderFramecallback, assign thepreviousFrameElementproperty (used elsewhere in thevisitCachedSnapshotcallback) to contain the contents of the currentframe, instead of the new frame.