Frames: Abort prior requests during navigation #418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanpdoyle
force-pushed
the
frame-cancel-pending-navigation-requests
branch
from
88feb79
to
3e4beca
Compare
packagethief
reviewed
Oct 4, 2021
Closes hotwired#417 --- If there is an unresolved `FetchRequest` in-flight when navigating a Turbo Frame, [abort][] its underlying [AbortController][] instance. [abort]: https://developer.mozilla.org/en-US/docs/Web/API/AbortController/abort [AbortController]: https://developer.mozilla.org/en-US/docs/Web/API/AbortController
seanpdoyle
force-pushed
the
frame-cancel-pending-navigation-requests
branch
from
3e4beca
to
7a7d836
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #417
If there is an unresolved
FetchRequestin-flight when navigating aTurbo Frame, abort its underlying AbortController instance.