Expand the FrameElementDelegate interface #402
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Expand the `FrameElementDelegate` to extend from both `FormInterceptorDelegate` and `LinkInterceptorDelegate`. After that change, replace conditionals in the `FrameRedirector` with calls to the `FrameElement` instance's delegate when one is found. This reduces the surface area for duplicate logic and improves guarantees of consistency across semantically similar situations.
seanpdoyle
force-pushed
the
frame-redirector-delegates
branch
from
96b06cf
to
e3ebaac
Compare
|
Closing this in favor of #430. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expand the
FrameElementDelegateto extend from bothFormInterceptorDelegateandLinkInterceptorDelegate.After that change, replace conditionals in the
FrameRedirectorwithcalls to the
FrameElementinstance's delegate when one is found.This reduces the surface area for duplicate logic and improves
guarantees of consistency across semantically similar situations.