Pass arbitrary dataset values to data-turbo-confirm via data-turbo-method links?

[danieldpence]

Following @excid3's awesome work in #525 enabling custom confirmation dialogs via data-turbo-confirm, I've run into a scenario where it doesn't seem like it's currently possible to pass additional information to the Turbo.setConfirmMethod function when data-turbo-confirm is placed on data-turbo-method links.

Consider:
I have a delete link:

<a data-turbo-method="delete" data-turbo-confirm="Are you sure?" data-title="My custom confirm title" data-type="negative" href="/delete/path">
Delete
</a>

Clicking that link causes a hidden form element to get created in order to trigger the form submission, here: https://github.com/hotwired/turbo/blob/main/src/observers/form_link_click_observer.ts#L33-L60

The problem is, only a subset of the dataset is passed along with the form element to the confirmMethod call.

In order to work around this, I'm manually querying the DOM for the original link via something like this:

window.Turbo.setConfirmMethod((message, element, submitter) => {
  let originalElement = submitter

  if (!submitter) {
    let matchingElements = document.querySelectorAll(
      `a[data-turbo-confirm="${message}"][data-turbo-method="${element.getAttribute('method')}"]`
    )
    originalElement = [...matchingElements].find((el) => element.action.includes(el.href))
  }

  const {
    type,
    title,
    turboConfirm: description,
    cancel,
    submit,
    turboConfirmDetail: eventDetail,
  } = originalElement.dataset

  ...
}

I'd love to be able to just pull those extra data attributes off of the element (the form element) instead. Would you be open to accepting a PR that allows that to be possible?

[dhh]

The element that has the data-confirm attribute should get passed along 👍

[excid3]

Just submitted #856 to fix this.

In the meantime, you should use button_to instead of a link_to if you need to access attributes in your custom confirm method.

[gucki]

@excid3 I can confirm this fixes this bug, but it doesn't play nice with ex. button groups of bootstrap :-(

[sansari]

Hi, I ended up needing to implement a similar workaround—curious if there are still plans to merge this? Thanks!