Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Correct
Render<E>
method signature argument order (#814)
* Correct `Render<E>` method signature argument order Closes [#812][] The order of the arguments in the `Render` signature are incorrect, and [were introduced in that incorrect order][incorrect]. Luckily, the default implementations and the tests that exercise that feature are in the correct order. The signature's argument order was inspired by [morphdom's](https://github.com/patrick-steele-idem/morphdom#usage), with the latter argument serving as overrides for the prior argument. Custom rendering isn't yet covered by Turbo's documentation website, so we have an opportunity to document it thoroughly and correctly, starting with TypeScript's understanding of the interface. [#812]: #812 [incorrect]: https://github.com/hotwired/turbo/pull/431/files#diff-d554b20c605a72c68b2d429ff9915cca4afa8e118026f56ede93382d130382a7R11 * Update `@playwright/test` dependency Our [CI][] is currently failing while executing `yarn run playwright install --with-deps`. This commit updates the dependency in an effort to resolve whatever underlying dependency issues are causing the failure. [CI]: https://github.com/hotwired/turbo/actions/runs/3664875382/jobs/6195570624#step:6:1
- Loading branch information