Document turbo:fetch-request-error event
#110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for proposing this change! Would it be worth differentiating between a For additional context, the originating call is made in the |
|
Could there be a distinction made with |
srt32
reviewed
Aug 15, 2022
|
👍🏽 thanks! |
seanpdoyle
approved these changes
Aug 15, 2022
seanpdoyle
reviewed
Aug 15, 2022
_source/reference/events.md
Outdated
| @@ -37,3 +37,5 @@ Turbo emits events that allow you to track the navigation lifecycle and respond | |||
| * `turbo:frame-render` fires right after `<turbo-frame>` element renders its view. The specific `<turbo-frame>` element is the event target. Access the `FetchResponse` object with `event.detail.fetchResponse` property. | |||
|
|
|||
| * `turbo:frame-load` fires when `<turbo-frame>` element is navigated and finishes loading (fires after `turbo:frame-render`). The specific `<turbo-frame>` element is the event target. | |||
|
|
|||
| * `turbo:fetch-request-error` fires when a form or frame fetch request fails due to network errors. This event fires on the respective element (turbo-frame or form element) which triggers it and can be accessed with `event.target` property. | |||
There was a problem hiding this comment.
Will this also fire during a Visit from an <a> click? Will the document.documentElement be the target?
There was a problem hiding this comment.
No, but perhaps it should? I think that would mean emitting this event here https://github.com/hotwired/turbo/blob/256418fee0178ee483d82cd9bb579bd5df5a151f/src/core/drive/visit.ts#L382
There was a problem hiding this comment.
I'm in favor of that change!
There was a problem hiding this comment.
I've opened hotwired/turbo#685 to add that behavior.
It also makes the turbo:fetch-request-error event cancelable, which is also worth noting here.
There was a problem hiding this comment.
What happens when the event is canceled? Or is it enough to just say “This event can be canceled”.
seanpdoyle
added a commit
to seanpdoyle/turbo
that referenced
this pull request
Aug 16, 2022
Follow-up to hotwired#640 Related to hotwired/turbo-site#110 When a `Visit` results in a `fetch` error (like when the browser is offline), dispatch a `turbo:fetch-request-error` event in the same style as `<turbo-frame>`- and `<form>`-initiated `fetch` errors. For the sake of consistency, also make the `TurboFetchRequestErrorEvent` cancelable. Along with the implementation change, this commit also adds test coverage to ensure that the `Event.target` is correct for `<turbo-frame>` and `<form>` error events.
seanpdoyle
added a commit
to seanpdoyle/turbo
that referenced
this pull request
Aug 16, 2022
Follow-up to hotwired#640 Related to hotwired/turbo-site#110 When a `Visit` results in a `fetch` error (like when the browser is offline), dispatch a `turbo:fetch-request-error` event in the same style as `<turbo-frame>`- and `<form>`-initiated `fetch` errors. For the sake of consistency, also make the `TurboFetchRequestErrorEvent` cancelable. Along with the implementation change, this commit also adds test coverage to ensure that the `Event.target` is correct for `<turbo-frame>` and `<form>` error events.
seanpdoyle
added a commit
to seanpdoyle/turbo
that referenced
this pull request
Aug 16, 2022
Follow-up to hotwired#640 Related to hotwired/turbo-site#110 When a `Visit` results in a `fetch` error (like when the browser is offline), dispatch a `turbo:fetch-request-error` event in the same style as `<turbo-frame>`- and `<form>`-initiated `fetch` errors. For the sake of consistency, also make the `TurboFetchRequestErrorEvent` cancelable. Along with the implementation change, this commit also adds test coverage to ensure that the `Event.target` is correct for `<turbo-frame>` and `<form>` error events.
seanpdoyle
added a commit
to seanpdoyle/turbo
that referenced
this pull request
Aug 16, 2022
Follow-up to hotwired#640 Related to hotwired/turbo-site#110 When a `Visit` results in a `fetch` error (like when the browser is offline), dispatch a `turbo:fetch-request-error` event in the same style as `<turbo-frame>`- and `<form>`-initiated `fetch` errors. For the sake of consistency, also make the `TurboFetchRequestErrorEvent` cancelable. Along with the implementation change, this commit also adds test coverage to ensure that the `Event.target` is correct for `<turbo-frame>` and `<form>` error events.
seanpdoyle
added a commit
to seanpdoyle/turbo
that referenced
this pull request
Aug 16, 2022
Follow-up to hotwired#640 Related to hotwired/turbo-site#110 When a `Visit` results in a `fetch` error (like when the browser is offline), dispatch a `turbo:fetch-request-error` event in the same style as `<turbo-frame>`- and `<form>`-initiated `fetch` errors. For the sake of consistency, also make the `TurboFetchRequestErrorEvent` cancelable. Along with the implementation change, this commit also adds test coverage to ensure that the `Event.target` is correct for `<turbo-frame>` and `<form>` error events.
seanpdoyle
added a commit
to seanpdoyle/turbo
that referenced
this pull request
Aug 16, 2022
Follow-up to hotwired#640 Related to hotwired/turbo-site#110 When a `Visit` results in a `fetch` error (like when the browser is offline), dispatch a `turbo:fetch-request-error` event in the same style as `<turbo-frame>`- and `<form>`-initiated `fetch` errors. For the sake of consistency, also make the `TurboFetchRequestErrorEvent` cancelable. Along with the implementation change, this commit also adds test coverage to ensure that the `Event.target` is correct for `<turbo-frame>` and `<form>` error events.
seanpdoyle
added a commit
to seanpdoyle/turbo
that referenced
this pull request
Aug 16, 2022
Follow-up to hotwired#640 Related to hotwired/turbo-site#110 When a `Visit` results in a `fetch` error (like when the browser is offline), dispatch a `turbo:fetch-request-error` event in the same style as `<turbo-frame>`- and `<form>`-initiated `fetch` errors. For the sake of consistency, also make the `TurboFetchRequestErrorEvent` cancelable. Along with the implementation change, this commit also adds test coverage to ensure that the `Event.target` is correct for `<turbo-frame>` and `<form>` error events.
seanpdoyle
added a commit
to seanpdoyle/turbo
that referenced
this pull request
Aug 16, 2022
Follow-up to hotwired#640 Related to hotwired/turbo-site#110 When a `Visit` results in a `fetch` error (like when the browser is offline), dispatch a `turbo:fetch-request-error` event in the same style as `<turbo-frame>`- and `<form>`-initiated `fetch` errors. For the sake of consistency, also make the `TurboFetchRequestErrorEvent` cancelable. Along with the implementation change, this commit also adds test coverage to ensure that the `Event.target` is correct for `<turbo-frame>` and `<form>` error events.
seanpdoyle
added a commit
to seanpdoyle/turbo
that referenced
this pull request
Aug 16, 2022
Follow-up to hotwired#640 Related to hotwired/turbo-site#110 When a `Visit` results in a `fetch` error (like when the browser is offline), dispatch a `turbo:fetch-request-error` event in the same style as `<turbo-frame>`- and `<form>`-initiated `fetch` errors. For the sake of consistency, also make the `TurboFetchRequestErrorEvent` cancelable. Along with the implementation change, this commit also adds test coverage to ensure that the `Event.target` is correct for `<turbo-frame>` and `<form>` error events.
seanpdoyle
added a commit
to seanpdoyle/turbo
that referenced
this pull request
Aug 16, 2022
Follow-up to hotwired#640 Related to hotwired/turbo-site#110 When a `Visit` results in a `fetch` error (like when the browser is offline), dispatch a `turbo:fetch-request-error` event in the same style as `<turbo-frame>`- and `<form>`-initiated `fetch` errors. For the sake of consistency, also make the `TurboFetchRequestErrorEvent` cancelable. Along with the implementation change, this commit also adds test coverage to ensure that the `Event.target` is correct for `<turbo-frame>` and `<form>` error events.
seanpdoyle
added a commit
to seanpdoyle/turbo
that referenced
this pull request
Aug 16, 2022
Follow-up to hotwired#640 Related to hotwired/turbo-site#110 When a `Visit` results in a `fetch` error (like when the browser is offline), dispatch a `turbo:fetch-request-error` event in the same style as `<turbo-frame>`- and `<form>`-initiated `fetch` errors. For the sake of consistency, also make the `TurboFetchRequestErrorEvent` cancelable. Along with the implementation change, this commit also adds test coverage to ensure that the `Event.target` is correct for `<turbo-frame>` and `<form>` error events.
seanpdoyle
added a commit
to seanpdoyle/turbo
that referenced
this pull request
Aug 16, 2022
Follow-up to hotwired#640 Related to hotwired/turbo-site#110 When a `Visit` results in a `fetch` error (like when the browser is offline), dispatch a `turbo:fetch-request-error` event in the same style as `<turbo-frame>`- and `<form>`-initiated `fetch` errors. For the sake of consistency, also make the `TurboFetchRequestErrorEvent` cancelable. Along with the implementation change, this commit also adds test coverage to ensure that the `Event.target` is correct for `<turbo-frame>` and `<form>` error events.
seanpdoyle
added a commit
to seanpdoyle/turbo
that referenced
this pull request
Aug 16, 2022
Follow-up to hotwired#640 Related to hotwired/turbo-site#110 When a `Visit` results in a `fetch` error (like when the browser is offline), dispatch a `turbo:fetch-request-error` event in the same style as `<turbo-frame>`- and `<form>`-initiated `fetch` errors. For the sake of consistency, also make the `TurboFetchRequestErrorEvent` cancelable. Along with the implementation change, this commit also adds test coverage to ensure that the `Event.target` is correct for `<turbo-frame>` and `<form>` error events.
seanpdoyle
added a commit
to seanpdoyle/turbo
that referenced
this pull request
Aug 16, 2022
Follow-up to hotwired#640 Related to hotwired/turbo-site#110 When a `Visit` results in a `fetch` error (like when the browser is offline), dispatch a `turbo:fetch-request-error` event in the same style as `<turbo-frame>`- and `<form>`-initiated `fetch` errors. For the sake of consistency, also make the `TurboFetchRequestErrorEvent` cancelable. Along with the implementation change, this commit also adds test coverage to ensure that the `Event.target` is correct for `<turbo-frame>` and `<form>` error events.
seanpdoyle
added a commit
to seanpdoyle/turbo
that referenced
this pull request
Aug 16, 2022
Follow-up to hotwired#640 Related to hotwired/turbo-site#110 When a `Visit` results in a `fetch` error (like when the browser is offline), dispatch a `turbo:fetch-request-error` event in the same style as `<turbo-frame>`- and `<form>`-initiated `fetch` errors. For the sake of consistency, also make the `TurboFetchRequestErrorEvent` cancelable. Along with the implementation change, this commit also adds test coverage to ensure that the `Event.target` is correct for `<turbo-frame>` and `<form>` error events.
seanpdoyle
added a commit
to seanpdoyle/turbo
that referenced
this pull request
Aug 16, 2022
Follow-up to hotwired#640 Related to hotwired/turbo-site#110 When a `Visit` results in a `fetch` error (like when the browser is offline), dispatch a `turbo:fetch-request-error` event in the same style as `<turbo-frame>`- and `<form>`-initiated `fetch` errors. For the sake of consistency, also make the `TurboFetchRequestErrorEvent` cancelable. Along with the implementation change, this commit also adds test coverage to ensure that the `Event.target` is correct for `<turbo-frame>` and `<form>` error events.
seanpdoyle
added a commit
to seanpdoyle/turbo
that referenced
this pull request
Aug 16, 2022
Follow-up to hotwired#640 Related to hotwired/turbo-site#110 When a `Visit` results in a `fetch` error (like when the browser is offline), dispatch a `turbo:fetch-request-error` event in the same style as `<turbo-frame>`- and `<form>`-initiated `fetch` errors. For the sake of consistency, also make the `TurboFetchRequestErrorEvent` cancelable. Along with the implementation change, this commit also adds test coverage to ensure that the `Event.target` is correct for `<turbo-frame>` and `<form>` error events.
seanpdoyle
added a commit
to seanpdoyle/turbo
that referenced
this pull request
Aug 16, 2022
Follow-up to hotwired#640 Related to hotwired/turbo-site#110 When a `Visit` results in a `fetch` error (like when the browser is offline), dispatch a `turbo:fetch-request-error` event in the same style as `<turbo-frame>`- and `<form>`-initiated `fetch` errors. For the sake of consistency, also make the `TurboFetchRequestErrorEvent` cancelable. Along with the implementation change, this commit also adds test coverage to ensure that the `Event.target` is correct for `<turbo-frame>` and `<form>` error events.
seanpdoyle
added a commit
to seanpdoyle/turbo
that referenced
this pull request
Aug 17, 2022
Follow-up to hotwired#640 Related to hotwired/turbo-site#110 When a `Visit` results in a `fetch` error (like when the browser is offline), dispatch a `turbo:fetch-request-error` event in the same style as `<turbo-frame>`- and `<form>`-initiated `fetch` errors. For the sake of consistency, also make the `TurboFetchRequestErrorEvent` cancelable. Along with the implementation change, this commit also adds test coverage to ensure that the `Event.target` is correct for `<turbo-frame>` and `<form>` error events.
seanpdoyle
added a commit
to seanpdoyle/turbo
that referenced
this pull request
Aug 17, 2022
Follow-up to hotwired#640 Related to hotwired/turbo-site#110 When a `Visit` results in a `fetch` error (like when the browser is offline), dispatch a `turbo:fetch-request-error` event in the same style as `<turbo-frame>`- and `<form>`-initiated `fetch` errors. For the sake of consistency, also make the `TurboFetchRequestErrorEvent` cancelable. Along with the implementation change, this commit also adds test coverage to ensure that the `Event.target` is correct for `<turbo-frame>` and `<form>` error events.
seanpdoyle
added a commit
to seanpdoyle/turbo
that referenced
this pull request
Sep 13, 2022
Follow-up to hotwired#640 Related to hotwired/turbo-site#110 When a `Visit` results in a `fetch` error (like when the browser is offline), dispatch a `turbo:fetch-request-error` event in the same style as `<turbo-frame>`- and `<form>`-initiated `fetch` errors. For the sake of consistency, also make the `TurboFetchRequestErrorEvent` cancelable. Along with the implementation change, this commit also adds test coverage to ensure that the `Event.target` is correct for `<turbo-frame>` and `<form>` error events.
seanpdoyle
added a commit
to seanpdoyle/turbo
that referenced
this pull request
Sep 13, 2022
Follow-up to hotwired#640 Related to hotwired/turbo-site#110 When a `Visit` results in a `fetch` error (like when the browser is offline), dispatch a `turbo:fetch-request-error` event in the same style as `<turbo-frame>`- and `<form>`-initiated `fetch` errors. For the sake of consistency, also make the `TurboFetchRequestErrorEvent` cancelable. Along with the implementation change, this commit also adds test coverage to ensure that the `Event.target` is correct for `<turbo-frame>` and `<form>` error events.
seanpdoyle
added a commit
to seanpdoyle/turbo
that referenced
this pull request
Sep 13, 2022
Follow-up to hotwired#640 Related to hotwired/turbo-site#110 When a `Visit` results in a `fetch` error (like when the browser is offline), dispatch a `turbo:fetch-request-error` event in the same style as `<turbo-frame>`- and `<form>`-initiated `fetch` errors. For the sake of consistency, also make the `TurboFetchRequestErrorEvent` cancelable. Along with the implementation change, this commit also adds test coverage to ensure that the `Event.target` is correct for `<turbo-frame>` and `<form>` error events.
seanpdoyle
added a commit
to seanpdoyle/turbo
that referenced
this pull request
Sep 14, 2022
Follow-up to hotwired#640 Related to hotwired/turbo-site#110 When a `Visit` results in a `fetch` error (like when the browser is offline), dispatch a `turbo:fetch-request-error` event in the same style as `<turbo-frame>`- and `<form>`-initiated `fetch` errors. For the sake of consistency, also make the `TurboFetchRequestErrorEvent` cancelable. Along with the implementation change, this commit also adds test coverage to ensure that the `Event.target` is correct for `<turbo-frame>` and `<form>` error events.
seanpdoyle
added a commit
to seanpdoyle/turbo
that referenced
this pull request
Sep 14, 2022
Follow-up to hotwired#640 Related to hotwired/turbo-site#110 When a `Visit` results in a `fetch` error (like when the browser is offline), dispatch a `turbo:fetch-request-error` event in the same style as `<turbo-frame>`- and `<form>`-initiated `fetch` errors. For the sake of consistency, also make the `TurboFetchRequestErrorEvent` cancelable. Along with the implementation change, this commit also adds test coverage to ensure that the `Event.target` is correct for `<turbo-frame>` and `<form>` error events.
seanpdoyle
added a commit
to seanpdoyle/turbo
that referenced
this pull request
Sep 14, 2022
Follow-up to hotwired#640 Related to hotwired/turbo-site#110 When a `Visit` results in a `fetch` error (like when the browser is offline), dispatch a `turbo:fetch-request-error` event in the same style as `<turbo-frame>`- and `<form>`-initiated `fetch` errors. For the sake of consistency, also make the `TurboFetchRequestErrorEvent` cancelable. Along with the implementation change, this commit also adds test coverage to ensure that the `Event.target` is correct for `<turbo-frame>` and `<form>` error events.
seanpdoyle
added a commit
to seanpdoyle/turbo
that referenced
this pull request
Sep 14, 2022
Follow-up to hotwired#640 Related to hotwired/turbo-site#110 When a `Visit` results in a `fetch` error (like when the browser is offline), dispatch a `turbo:fetch-request-error` event in the same style as `<turbo-frame>`- and `<form>`-initiated `fetch` errors. For the sake of consistency, also make the `TurboFetchRequestErrorEvent` cancelable. Along with the implementation change, this commit also adds test coverage to ensure that the `Event.target` is correct for `<turbo-frame>` and `<form>` error events.
seanpdoyle
added a commit
to seanpdoyle/turbo
that referenced
this pull request
Sep 14, 2022
Follow-up to hotwired#640 Related to hotwired/turbo-site#110 When a `Visit` results in a `fetch` error (like when the browser is offline), dispatch a `turbo:fetch-request-error` event in the same style as `<turbo-frame>`- and `<form>`-initiated `fetch` errors. For the sake of consistency, also make the `TurboFetchRequestErrorEvent` cancelable. Along with the implementation change, this commit also adds test coverage to ensure that the `Event.target` is correct for `<turbo-frame>` and `<form>` error events.
dhh
pushed a commit
to hotwired/turbo
that referenced
this pull request
Sep 14, 2022
Follow-up to #640 Related to hotwired/turbo-site#110 When a `Visit` results in a `fetch` error (like when the browser is offline), dispatch a `turbo:fetch-request-error` event in the same style as `<turbo-frame>`- and `<form>`-initiated `fetch` errors. For the sake of consistency, also make the `TurboFetchRequestErrorEvent` cancelable. Along with the implementation change, this commit also adds test coverage to ensure that the `Event.target` is correct for `<turbo-frame>` and `<form>` error events.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See hotwired/turbo#640