data-disable-with #37
Comments
|
I found where I had read something that mentioned data-disable-with and turbo in the same conversation. I wasn't able to find anything beyond these mentionings: https://discourse.stimulusjs.org/t/stimulus-and-rails-ujs/587/10 |
|
Documented the compatibility with turbo-rails and UJS. And we've also stopped taking UJS out when using the Webpack installer. |
|
The link above didn't work for me, but here is where I found the documentation you mention: https://github.com/hotwired/turbo-rails#compatibility-with-rails-ujs |
|
Also, seems duplicate of hotwired/turbo#55. I solved with @seanpdoyle polyfill. |
seanpdoyle
added a commit
to seanpdoyle/turbo-rails
that referenced
this issue
Jan 25, 2021
Closes hotwired#33. Closes hotwired#37. --- Re-create [hotwired/turbo#40][]. When loaded alongside [@rails/ujs][], start it via `Rails.start()`, and then declare the [`turbo:`-prefixed events][turbo-events] that correspond to their `ajax:`-prefixed counterparts. Test suite changes --- First, introduce System Test coverage to drive the Turbo and Rails integration through a headless browser. Next, change some dummy controller actions to accept a `?sleep=` query parameter to delay their responses long enough to ensure that `data-disabled-with` and `data-confirm` have a wide enough window of opportunity for test coverage to exercise their behaviors. [hotwired/turbo#40]: hotwired/turbo#40 [@rails/ujs]: https://github.com/rails/rails/tree/v6.1.0/actionview/app/assets/javascripts [turbo-events]: https://turbo.hotwire.dev/reference/events
seanpdoyle
added a commit
to seanpdoyle/turbo-rails
that referenced
this issue
Jan 25, 2021
Closes hotwired#33. Closes hotwired#37. --- Re-create [hotwired/turbo#40][]. When loaded alongside [@rails/ujs][], start it via `Rails.start()`, and then declare the [`turbo:`-prefixed events][turbo-events] that correspond to their `ajax:`-prefixed counterparts. Test suite changes --- First, introduce System Test coverage to drive the Turbo and Rails integration through a headless browser. Next, change some dummy controller actions to accept a `?sleep=` query parameter to delay their responses long enough to ensure that `data-disabled-with` and `data-confirm` have a wide enough window of opportunity for test coverage to exercise their behaviors. [hotwired/turbo#40]: hotwired/turbo#40 [@rails/ujs]: https://github.com/rails/rails/tree/v6.1.0/actionview/app/assets/javascripts [turbo-events]: https://turbo.hotwire.dev/reference/events
seanpdoyle
added a commit
to seanpdoyle/turbo-rails
that referenced
this issue
Jan 25, 2021
Closes hotwired#33. Closes hotwired#37. --- Re-create [hotwired/turbo#40][]. When loaded alongside [@rails/ujs][], start it via `Rails.start()`, and then declare the [`turbo:`-prefixed events][turbo-events] that correspond to their `ajax:`-prefixed counterparts. Test suite changes --- First, introduce System Test coverage to drive the Turbo and Rails integration through a headless browser. Next, change some dummy controller actions to accept a `?sleep=` query parameter to delay their responses long enough to ensure that `data-disabled-with` and `data-confirm` have a wide enough window of opportunity for test coverage to exercise their behaviors. [hotwired/turbo#40]: hotwired/turbo#40 [@rails/ujs]: https://github.com/rails/rails/tree/v6.1.0/actionview/app/assets/javascripts [turbo-events]: https://turbo.hotwire.dev/reference/events
seanpdoyle
added a commit
to seanpdoyle/turbo-rails
that referenced
this issue
Jan 25, 2021
Closes hotwired#33. Closes hotwired#37. --- Re-create [hotwired/turbo#40][]. When loaded alongside [@rails/ujs][], start it via `Rails.start()`, and then declare the [`turbo:`-prefixed events][turbo-events] that correspond to their `ajax:`-prefixed counterparts. Test suite changes --- First, introduce System Test coverage to drive the Turbo and Rails integration through a headless browser. Next, change some dummy controller actions to accept a `?sleep=` query parameter to delay their responses long enough to ensure that `data-disabled-with` and `data-confirm` have a wide enough window of opportunity for test coverage to exercise their behaviors. [hotwired/turbo#40]: hotwired/turbo#40 [@rails/ujs]: https://github.com/rails/rails/tree/v6.1.0/actionview/app/assets/javascripts [turbo-events]: https://turbo.hotwire.dev/reference/events
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hello,
I thought I had read something about data-disable-with related to turbo-rails, but I can't find it in my history anywhere. I notice that
data: { disable_with: '...' }doesn't seem to work anymore when making the transition to turbo-rails from turbolinks and rails-ujs.I wasn't quite sure what made data-disable-with work in the past, but I'm assuming it was rails-ujs since it doesn't seem to be related to turbolinks and the only other thing I removed to make way for turbo-rails was rails-ujs.
Are we planning on having data-disable-with functionality restored? Or is this something we should implement ourselves from here on out?
I've really enjoyed learning about the new magic, thanks for all the efforts!
The text was updated successfully, but these errors were encountered: