Handle soft-deletes as regular deletes for Turbo Stream #16
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @tonysm,
I don't think soft-deletes are handle as regular deletes right now for default Turbo Stream.
According to this line: https://github.com/tonysm/turbo-laravel/blob/0.3.2/src/TurboStreamResponseMacro.php#L19
You check if the model exists, but a soft deleted model response to
true
on thisexists
attribute.In this pull request I add the fix below and a corresponding test:
If you remove my fix, the new test will failed with this error:
Reference:
#5 (comment)
Have a good day,
Tortue Torche