Implemented: Code to show app version & build information on Settings page(#85zrhn8w8) #341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… page(#85zrhn8w8)
…roperties, used subtitle and title to display userName, also fixed styling of app version and built information(#85zrhn8w8)
adityasharma7
suggested changes
Jan 10, 2023
src/views/Settings.vue
Outdated
| @@ -157,6 +169,9 @@ export default defineComponent({ | |||
| currentShopifyConfig: 'user/getCurrentShopifyConfig', | |||
| }) | |||
| }, | |||
| mounted() { | |||
| this.appVersion = this.appInfo.version; | |||
There was a problem hiding this comment.
We will show branch + revision if available, else tag
https://github.com/hotwax/ionic-sdk/pull/84/files#diff-817427b0a52f22c1023629bd0728cd3102a9dd01cb780ef55f79d99ec24c23e6R78
…nd if not then tag name(#85zrhn8w8)
shashwatbangar
force-pushed
the
#85zrhn8w8
branch
from
e3c951f to
aa1a1dc
Compare
adityasharma7
approved these changes
Jan 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Closes
Short Description and Why It's Useful
Screenshots of Visual Changes before/after (If There Are Any)
IMPORTANT NOTICE - Remember to add changelog entry
Contribution and Currently Important Rules Acceptance