Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented: support to make packing slip, shipping label and print picklist functional(#1xx6rd3) #107

Merged
merged 17 commits into from
Apr 25, 2023

Conversation

ymaheshwari1
Copy link
Contributor

@ymaheshwari1 ymaheshwari1 commented Apr 21, 2023

Related Issues

Closes #106

Short Description and Why It's Useful

  • Removed usage of addShipmentPackage service and used addShipmentPackage api instead
  • Transformed the response of inProgress orders
  • Made the print options functional on settings page
  • Disabled viewSize selector button when no orders found

Screenshots of Visual Changes before/after (If There Are Any)

IMPORTANT NOTICE - Remember to add changelog entry

Contribution and Currently Important Rules Acceptance

…late section as per the updated order structure and replaced usage of addShipmentPackage service with addShipmentPackage api(#1xx6rd3)
… made the options of documents printing on settings page functional(#1xx6rd3)
@ymaheshwari1 ymaheshwari1 changed the title #1xx6rd3 [WIP] #1xx6rd3 Apr 21, 2023
@ymaheshwari1 ymaheshwari1 changed the title [WIP] #1xx6rd3 Implemented: support to make packing slip, shipping label and print picklist functional(#1xx6rd3) Apr 24, 2023
@@ -20,7 +20,7 @@ const fetchPicklistInformation = async (query: any): Promise <any> => {
}

const findShipmentIdsForOrders = async(picklistBinIds: Array<string>, orderIds: Array<string>): Promise<any> => {
let shipmentIds = [];
let shipmentIds = {};
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
let shipmentIds = {};
let shipmentIdsForOrders = {};

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create packing slip pdf
2 participants