Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Icon overlaps text on 'Review Shipment' Page when scrolling to bottom of screen. #431

Closed
Adameddy26 opened this issue Feb 27, 2024 · 2 comments
Closed

Icon overlaps text on 'Review Shipment' Page when scrolling to bottom of screen. #431

Adameddy26 opened this issue Feb 27, 2024 · 2 comments
Assignees
@Adameddy26
Labels
bug Something isn't working release-2.0.3 Release 2.0.3

Comments

@Adameddy26
Copy link

Expected behavior

When scrolling down to the bottom of the 'Review Shipment' page, all elements, including icons and text, should remain properly spaced and displayed without overlapping. Users should be able to read the text without any visual obstruction caused by overlapping elements.

Steps to reproduce the issue

Log in the App with valid credentials.
Go to Transfer Orders(TO) section and open any TO.
Manually enter the quantity for shipment for multiple products or simply scan the products and then update their quantity.
Navigate to the "Review Shipment" page.
Scroll down to the bottom of screen.
Observe the issue.

Environment details

App version: TRANSFER-ORDER-UI-451FBD7
App Environment: UAT

Additional information

Screenshot 2024-02-27 at 12 20 43 PM
@Adameddy26 Adameddy26 added the bug Something isn't working label Feb 27, 2024
@Adameddy26 Adameddy26 moved this to 📋 Backlog in Digital Experience Platform Feb 27, 2024
@dt2patel
Copy link
Contributor

Reference implementation in facilities app modal I think for more details around this.

@amansinghbais amansinghbais moved this from 📋 Backlog to 📅 Planned in Digital Experience Platform Mar 11, 2024
@Ritika-Patel08 Ritika-Patel08 moved this from 📅 Planned to 🏗 In progress in Digital Experience Platform Mar 12, 2024
Ritika-Patel08 added a commit to Ritika-Patel08/fulfillment-pwa that referenced this issue Mar 12, 2024
@Ritika-Patel08
Fixed: code by adding css to ion-content to remove the overlapping of…
fd6a4d1 
… icon and text(hotwax#431)
@Ritika-Patel08 Ritika-Patel08 mentioned this issue Mar 12, 2024
Merged
1 task
@Ritika-Patel08 Ritika-Patel08 moved this from 🏗 In progress to 👀 In review in Digital Experience Platform Mar 12, 2024
ravilodhi added a commit that referenced this issue Mar 13, 2024
@ravilodhi
Merge pull request #447 from Ritika-Patel08/#431
aef23dc 
Fixed: code by adding css to ion-content to remove the overlapping of icon and text(#431)
@ymaheshwari1 ymaheshwari1 moved this from 👀 In review to ⏸️ Dev complete in Digital Experience Platform Mar 13, 2024
@Adameddy26 Adameddy26 added the release-2.0.3 Release 2.0.3 label Mar 13, 2024
@Adameddy26 Adameddy26 moved this from ⏸️ Dev complete to ✅ Done in Digital Experience Platform Mar 13, 2024
@Adameddy26
Copy link
Author

Issue verified and working fine in 2.0.3.
https://jam.dev/c/cff72736-2e37-4ff3-bb24-73289a426172

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Adameddy26 Adameddy26

Labels
bug Something isn't working release-2.0.3 Release 2.0.3
Projects
Digital Experience Platform
Archived in project
Milestone
No milestone
Development

No branches or pull requests
4 participants
@ravilodhi @dt2patel @Ritika-Patel08 @Adameddy26