Fixed build console warnings (threshold-management/#69) #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ymaheshwari1
requested changes
May 10, 2022
|
Reopen, |
|
Ok, sir I'll not push it from next time |
rathoreprashant
force-pushed
the
threshold-management/#69
branch
from
586a149 to
b0fa793
Compare
adityasharma7
suggested changes
May 11, 2022
src/store/modules/user/actions.ts
Outdated
| commit(types.USER_INSTANCE_URL_UPDATED, payload) | ||
| }, | ||
|
|
||
| async getEComStores({ commit }, payload) { | ||
| async getEComStores(payload) { |
There was a problem hiding this comment.
I think this will cause abrupt behaviour of this action. If we are not doing anything related to state we should rather create service
adityasharma7
suggested changes
May 23, 2022
src/store/modules/user/actions.ts
Outdated
| resp.data.stores = stores ? stores : []; | ||
| commit(types.USER_CURRENT_ECOM_STORE_UPDATED, stores ? stores[0] : {}); | ||
| }); | ||
| const newresp = await UserService.getEComStores(payload); |
There was a problem hiding this comment.
Improve variable name
https://google.github.io/styleguide/jsguide.html
There was a problem hiding this comment.
Improved sir Please have a look
adityasharma7
approved these changes
May 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed Unwanted Definitions and Assignments
Definitions
img.onerror = function (error)import { translate } from "@/i18n";setUserInstanceUrl ({ state, commit }, payload){async getEComStores({ commit }, payload) {async setEComStore({ commit, dispatch }, payload) {import { IonBackButton, IonButton, IonContent, IonHeader,IonIcon, IonItem, IonLabel, IonMenuButton, IonPage, IonSelect, IonSelectOption, IonTitle, IonToolbar, popoverController } from '@ionic/vue';import emitter from '@/event-bus';Assignments
const cachedEnum = payload.map((id: any) => state.enumIds[id]);const cachedTempExpr = tempExprIds.map((id: any) => state.temporalExp[id]);