Implemented: logic to use filters modal for selecting or removing a filter and removed faceting logic(#29wm19n) #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ymaheshwari1
commented
May 6, 2022
•
ymaheshwari1
commented
- Bind the search filter modal with the add button on the search product page
- Made the options in the modal dynamic on the basis of search query in the modal
- Removed logic to get the facets from solr-query on initial page load
- Created state for storing the query and action to update the query
- Created state for storing the filters and action, mutations for updating the filters
- Improved logic to define infinite scroll.
- Implemented functionality to clear filters and reset filters
…ayed the options in the modal(#29wm19n)
…lr and defined state to store the applied filters(#29wm19n)
…d filters(#29wm19n)
…update the solr query(#29wm19n)
…another type or not(#29wm19n)
…e it when fetching or applying the filters(#29wm19n)
…ove some unwanted code(#29wm19n)
ymaheshwari1
changed the title
…get the query, removed some unwanted console statements and updated logic to prepare the query when having empty query string(#29wm19n)
…c to check if the current value is in another type(#29wm19n)
…clear all button(#29wm19n)
adityasharma7
suggested changes
May 6, 2022
| dispatch('updateQuery') | ||
| }, | ||
|
|
||
| async updateQuery({ commit, dispatch, state }, payload) { |
There was a problem hiding this comment.
We could implement a method to prepare query and have only 2 actions update filter & get products. Could be a separate task
There was a problem hiding this comment.
Sure Sir, will handle this in another PR, created a ticket for the same.
src/store/modules/product/actions.ts
Outdated
| // done this as for now not creating a separate mutation for this or updating current mutation logic | ||
| // as per this functionality | ||
| // TODO: update this logic to simply update the filters state | ||
| Object.keys(appliedFilters).map((id: any) => { |
There was a problem hiding this comment.
We could have a single mutation to reset all
There was a problem hiding this comment.
Defined a single mutation to reset the filter.
src/views/SelectProduct.vue
Outdated
| totalSKUs: this.products.total.variant | ||
| } | ||
| }) | ||
|
|
||
| saveThresholdModal.present(); | ||
| }, | ||
| async openSearchModal(label: string, facetToSelect: string, searchfield: string, type: string) { |
There was a problem hiding this comment.
Suggested change
| async openSearchModal(label: string, facetToSelect: string, searchfield: string, type: string) { | |
| async searchFilter(label: string, facetToSelect: string, searchfield: string, type: string) { |
…en updating the filters(#29wm19n)
…ring it, and improved the variable name(#29wm19n)
adityasharma7
approved these changes
May 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.