Implemented: logic to create search preference and schedule a service (#29bdb9f) #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the button on the search page(#29bdb9f)
…tion to schedule a job(#29bdb9f)
…d scheduling the job(#29bdb9f)
…threshold(#29bdb9f)
…ference and stringify the query when storing it in preference, also passed viewSize when fetching the data for jobs(#29bdb9f)
adityasharma7
suggested changes
May 5, 2022
|
|
||
| <ion-item> | ||
| <ion-label>{{ $t("Rule name") }}</ion-label> | ||
| <ion-input placeholder="rule name" v-model="jobName"/> |
There was a problem hiding this comment.
Internationalise placeholder
There was a problem hiding this comment.
Added placeholder in internationalization file
| closeModal() { | ||
| modalController.dismiss({ dismissed: true }); | ||
| }, | ||
| async createSearchPreference() { |
There was a problem hiding this comment.
Suggested change
| async createSearchPreference() { | |
| async saveThresholdRule() { |
There was a problem hiding this comment.
Improved method name
src/store/modules/util/actions.ts
Outdated
| }, | ||
| "entityName": "ShopifyConfig", | ||
| "noConditionFind": "Y", | ||
| "fieldList": ["shopifyConfigId", "productStoreId"] |
There was a problem hiding this comment.
For now added viewSize as 1.
src/views/SelectProduct.vue
Outdated
| }, | ||
| methods: { | ||
| updateInclusionQuery(value: string, type: string) { | ||
| this.included[type].includes(value) ? this.included[type].splice(this.included[type].indexOf(value), 1) : this.included[type].push(value) |
There was a problem hiding this comment.
Assign this.included[type] to a variable and then use
src/views/SelectProduct.vue
Outdated
| // to remove that value from the query filter | ||
| this.query.json['filter'] = ["docType: PRODUCT"] | ||
|
|
||
| this.included['tags'].length > 0 && this.query.json['filter'].push(`tags: (${this.included['tags'].join(' OR ')})`) |
There was a problem hiding this comment.
We could iterate using reduce and prepare it dynamically
There was a problem hiding this comment.
Sir, used reduce to prepare the query.
…d method name and updated en.json file(#29bdb9f)
…l dynamic(#29bdb9f)
…shopify config id(#29bdb9f)
adityasharma7
approved these changes
May 5, 2022
adityasharma7
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.