Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implemented static UI of select product screen (#1x69ahw) #3

Merged
merged 16 commits into from
Jan 28, 2022
Merged

Implemented static UI of select product screen (#1x69ahw) #3

merged 16 commits into from
Jan 28, 2022

Conversation

azkyakhan
Copy link
Contributor

No description provided.

@azkyakhan
Copy link
Contributor Author

azkyakhan commented Jan 11, 2022 •
edited
Loading

select-productt

select-product-menu

select-product-mobile

select-productt-csv-upload

@azkyakhan azkyakhan requested a review from dt2patel January 11, 2022 08:09
@azkyakhan azkyakhan marked this pull request as ready for review January 11, 2022 08:09
@azkyakhan azkyakhan marked this pull request as draft January 11, 2022 08:58
@azkyakhan azkyakhan marked this pull request as ready for review January 11, 2022 09:21
dt2patel
dt2patel requested changes Jan 13, 2022
View reviewed changes
Copy link
Contributor

@dt2patel dt2patel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes to css

src/App.vue Show resolved Hide resolved
src/views/SelectProductCSVUpload.vue Outdated Show resolved Hide resolved
src/views/SelectProduct.vue Outdated Show resolved Hide resolved
@azkyakhan azkyakhan requested a review from dt2patel January 17, 2022 09:03
dt2patel
dt2patel requested changes Jan 23, 2022
View reviewed changes
Copy link
Contributor

@dt2patel dt2patel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments

src/views/SelectProduct.vue Outdated
.action {
position: fixed;
bottom: 100px;
left: 850px;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not the best way to absolutely position the button in the center of the main div

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done sir
action-button

@azkyakhan azkyakhan requested a review from dt2patel January 24, 2022 16:26
@dt2patel dt2patel assigned dt2patel and azkyakhan and unassigned dt2patel Jan 27, 2022
@dt2patel dt2patel merged commit 4603cfb into hotwax:main Jan 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dt2patel dt2patel dt2patel approved these changes

Assignees

@azkyakhan azkyakhan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@azkyakhan @dt2patel